From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <JBeulich@novell.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
tglx@linutronix.de, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
hpa@zytor.com
Subject: Re: [PATCH] x86: adjust GFP mask handling for coherent allocations
Date: Mon, 26 Oct 2009 21:19:17 +0100 [thread overview]
Message-ID: <20091026201917.GE24682@elte.hu> (raw)
In-Reply-To: <4AE5D238020000780001BD46@vpn.id2.novell.com>
* Jan Beulich <JBeulich@novell.com> wrote:
> >>> Ingo Molnar <mingo@elte.hu> 26.10.09 16:22 >>>
> >* Jan Beulich <JBeulich@novell.com> wrote:
> >> And any attempt to eliminate the conditional another way would just
> >> introduce a very similar conditional elsewhere; with this having a
> >> single user (and foreseeably not ever a second one) I would think this
> >> would just make the code less readable.
> >
> >There's 3 other current uses of DMA_BIT_MASK(24) in arch/x86 - couldnt
> >those use ISA_DMA_BIT_MASK too?
>
> Oh, so you didn't mean me to eliminate the conditional in pci-dma.c,
> but just to replace the DMA_BIT_MASK(24) here an elsewhere. Sure, I'm
> fine with adding this to the patch.
Well, can ISA_BIT_MASK fall back to DMA_BIT_MASK(32) on !CONFIG_ISA? If
we have ISA support disabled we might as well pretend the whole world is
PCI, right?
That way we'd get rid of that #ifdef in the .c code too.
Ingo
next prev parent reply other threads:[~2009-10-26 20:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 12:03 [PATCH] x86: adjust GFP mask handling for coherent allocations Jan Beulich
2009-10-23 11:48 ` Ingo Molnar
2009-10-26 15:13 ` Jan Beulich
2009-10-26 15:22 ` Ingo Molnar
2009-10-26 15:45 ` Jan Beulich
2009-10-26 20:19 ` Ingo Molnar [this message]
2009-10-26 20:44 ` Jesse Barnes
2009-10-27 1:38 ` FUJITA Tomonori
2009-10-27 8:58 ` Jan Beulich
2009-10-27 9:00 ` Jan Beulich
2009-10-27 9:11 ` FUJITA Tomonori
2009-10-27 9:23 ` Jan Beulich
2009-10-27 9:37 ` FUJITA Tomonori
2009-10-27 9:47 ` Jan Beulich
2009-10-27 10:15 ` FUJITA Tomonori
2009-10-27 10:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026201917.GE24682@elte.hu \
--to=mingo@elte.hu \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox