From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Am??rico Wang <xiyou.wangcong@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] Expose MSI-X interrupts through a dynamically generated sysfs directory
Date: Tue, 27 Oct 2009 10:32:47 -0700 [thread overview]
Message-ID: <20091027173247.GA23368@kroah.com> (raw)
In-Reply-To: <20091020082602.GA979@parisc-linux.org>
On Tue, Oct 20, 2009 at 02:26:02AM -0600, Matthew Wilcox wrote:
> On Tue, Oct 20, 2009 at 04:14:44PM +0800, Am??rico Wang wrote:
> > On Tue, Oct 20, 2009 at 1:50 PM, Matthew Wilcox <matthew@wil.cx> wrote:
> > > +#define kobj_to_pci_dev(obj) to_pci_dev(container_of(obj, struct device, kobj))
> >
> > You define this, but no one uses it?
>
> Yeah, left over from an earlier version of the patch. Thanks, I'll
> remove it.
>
> > > + ?? ?? ?? array = kmalloc((nr_irqs + 1) * sizeof(void *), GFP_KERNEL);
> > > + ?? ?? ?? if (!array)
> > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM;
> > > + ?? ?? ?? attr = kmalloc(nr_irqs * sizeof(*attr), GFP_KERNEL);
> > > + ?? ?? ?? if (!attr)
> > > + ?? ?? ?? ?? ?? ?? ?? return -ENOMEM;
> >
> > Here leaks memory allocated above.
>
> Oh, yeah, duh, thanks.
Care to resend this series with these fixes?
thanks,
greg k-h
next prev parent reply other threads:[~2009-10-27 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 5:47 [PATCH 0/3] Allow sysfs to be dynamically populated Matthew Wilcox
2009-10-20 5:49 ` [PATCH 1/3] Fix updating of named attribute groups Matthew Wilcox
2009-10-29 15:59 ` Tejun Heo
2009-10-29 16:19 ` Matthew Wilcox
2009-10-29 16:24 ` Tejun Heo
2009-10-20 5:50 ` [PATCH 2/3] Sysfs: Allow directories to be populated dynamically Matthew Wilcox
2009-10-29 16:20 ` Tejun Heo
2009-10-29 16:21 ` Matthew Wilcox
2009-10-29 16:28 ` Tejun Heo
2009-10-29 19:24 ` Matthew Wilcox
2009-10-30 10:17 ` Tejun Heo
2009-10-30 11:14 ` Matthew Wilcox
2009-10-30 16:06 ` Tejun Heo
2009-10-20 5:50 ` [PATCH 3/3] Expose MSI-X interrupts through a dynamically generated sysfs directory Matthew Wilcox
2009-10-20 8:14 ` Américo Wang
2009-10-20 8:26 ` Matthew Wilcox
2009-10-27 17:32 ` Greg KH [this message]
2009-10-20 5:52 ` [PATCH 0/3] Allow sysfs to be dynamically populated Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027173247.GA23368@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox