From: Marek Vasut <marek.vasut@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Ondrej Zajicek <santiago@crfreenet.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard
Date: Wed, 28 Oct 2009 02:37:40 +0100 [thread overview]
Message-ID: <200910280237.40268.marek.vasut@gmail.com> (raw)
In-Reply-To: <f17812d70910270043q328ab091mb1d76760e674450d@mail.gmail.com>
Dne Út 27. října 2009 08:43:44 Eric Miao napsal(a):
> On Tue, Oct 27, 2009 at 6:59 AM, Ondrej Zajicek <santiago@crfreenet.org>
wrote:
> > Palm Tungsten C keyboard structure has swapped
> > rows/cols gpio structures and does not work.
> > This patch fixes it.
> >
> > Signed-off-by: Ondrej Zajicek <santiago@crfreenet.org>
>
> This fix looks obvious to me. Applied to 'fix'.
Just wondering ... you checked the GPIO directions, right ? I mean, it works in
both directions, it just works worse the other one. I can't really check now.
Also, it'll be possibly good to use the following emails for pxa patches:
Eric Miao <eric.y.miao@gmail.com>
Linux-ARM-Kernel <linux-arm-kernel@lists.infradead.org>
Marek Vasut <marek.vasut@gmail.com>
Those should be enough.
Cheers!
>
> > diff -uprN linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c
> > linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c ---
> > linux-2.6.32-rc5-old/arch/arm/mach-pxa/palmtc.c 2009-10-16
> > 02:41:50.000000000 +0200 +++ linux-2.6.32-rc5/arch/arm/mach-pxa/palmtc.c
> > 2009-10-26 20:56:44.000000000 +0100 @@ -292,10 +292,10 @@ const static
> > unsigned int palmtc_keypad_
> >
> > static struct matrix_keypad_platform_data palmtc_keypad_platform_data =
> > { .keymap_data = &palmtc_keymap_data,
> > - .col_gpios = palmtc_keypad_row_gpios,
> > - .num_col_gpios = 12,
> > - .row_gpios = palmtc_keypad_col_gpios,
> > - .num_row_gpios = 4,
> > + .row_gpios = palmtc_keypad_row_gpios,
> > + .num_row_gpios = ARRAY_SIZE(palmtc_keypad_row_gpios),
> > + .col_gpios = palmtc_keypad_col_gpios,
> > + .num_col_gpios = ARRAY_SIZE(palmtc_keypad_col_gpios),
> > .active_low = 1,
> >
> > .debounce_ms = 20,
> >
> >
> > --
> > Elen sila lumenn' omentielvo
> >
> > Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org)
> > OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
> > "To err is human -- to blame it on a computer is even more so."
>
next prev parent reply other threads:[~2009-10-28 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 22:59 [PATCH] 2.6.32-rc5 bug in Palm Tungsten C keyboard Ondrej Zajicek
2009-10-27 7:43 ` Eric Miao
2009-10-28 1:37 ` Marek Vasut [this message]
2009-10-28 1:55 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910280237.40268.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santiago@crfreenet.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox