Re: is avoiding compat ioctls possible?

Dave Airlie
2009-10-28T05:42:25Z

> Please don't do this.
>
> This is exactly what I feared people would do when is_compat_task()
> was added. is_compat_task() is for situations where there is
> otherwise no other way to handle the compat situation properly.
>
> It's not that much work for you to hook up the compat ioctls properly,
> and if you are clever you can do it in such a way that you'll get
> warnings if someone accidently adds a new ioctl but forgets the
> compat bits :-)

There are close to 15 ioctls needing this, so I can add 15 functions to
unpack and repack stuff or I can add that function, sorry if I'm
leaning towards a lighter weight solution. I'll add this to my TODO for
before the next merge window as its definitely more than I can manage now.

Dave.