public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: zach.brown@oracle.com, linux-aio <linux-aio@kvack.org>,
	Linux Kernel Mailing <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch v4 0/3] aio: implement request batching [more performance numbers]
Date: Wed, 28 Oct 2009 09:28:54 +0100	[thread overview]
Message-ID: <20091028082854.GU10727@kernel.dk> (raw)
In-Reply-To: <x49hbtk24o9.fsf@segfault.boston.devel.redhat.com>

On Tue, Oct 27 2009, Jeff Moyer wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
> 
> >> > Nice numbers! The patch looks good to me from a quick look, if you want
> >> > I can throw it into the testing mix tomorrow and see what kind of
> >> > improvements I see here. With performance increase of that magnitude, we
> >> > should get it in sooner rather than later.
> >> 
> > So here's a pretty basic test. It does random reads from a bunch of
> > devices, I tested both 4kb and 64kb block sizes. Queue depth used is 32
> > for both cases, but note that this test uses a thread per device (so the
> > queue depth is 32 per device). Results are averaged over 3 runs.
> > slat/clat are the submission and completion latencies, they are in
> > microseconds here.
> [...]
> > So pretty close, nothing earth shattering here. What the results above
> > do not show is that the 4kb test runs very stable with your patch.
> > Mainline fluctuates somewhat in the bandwidth, most likely due to the
> > varying depth.
> 
> OK, I don't think this patch set will see further testing without
> pulling it into someone's tree.  Jens, would you mind putting this into
> your for-2.6.33 queue?  Let me know if you need me to resend the
> patches.

Sure, I'll pull it in. I still have the patches, will ping you if it
doesn't apply cleanly.

-- 
Jens Axboe


      reply	other threads:[~2009-10-28  8:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 22:54 [patch v4 0/3] aio: implement request batching Jeff Moyer
2009-10-02 22:56 ` [patch v4 1/2] block: get rid of the WRITE_ODIRECT flag Jeff Moyer
2009-10-02 22:57 ` [patch v4 2/2] aio: implement request batching Jeff Moyer
2009-10-02 22:58 ` [patch v4 0/3] " Jeff Moyer
2009-10-06 17:45 ` [patch v4 0/3] aio: implement request batching [more performance numbers] Jeff Moyer
2009-10-06 18:06   ` Jens Axboe
2009-10-06 18:18     ` Jeff Moyer
2009-10-07 10:52       ` Jens Axboe
2009-10-07 12:09         ` Jeff Moyer
2009-10-27 16:16         ` Jeff Moyer
2009-10-28  8:28           ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028082854.GU10727@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox