From: bart.hartgers@gmail.com
To: Greg Kroah-Hartman <gregkh@suse.de>, Mike McCormack <mikem@ring3k.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart Hartgers <bart.hartgers@gmail.com>
Subject: [PATCH 6/6] ark3116: (v2) Cleanup of now unneeded functions
Date: Wed, 28 Oct 2009 10:43:30 +0100 [thread overview]
Message-ID: <20091028095112.823213217@gmail.com> (raw)
In-Reply-To: 20091028094324.010816897@gmail.com
[-- Attachment #1: 0035_ark3116_cleanup.patch --]
[-- Type: text/plain, Size: 1681 bytes --]
Signed-off-by: Bart Hartgers <bart.hartgers@gmail.com>
---
Index: linux-2.6.32-rc4/drivers/usb/serial/ark3116.c
===================================================================
--- linux-2.6.32-rc4.orig/drivers/usb/serial/ark3116.c 2009-10-28 10:19:47.000000000 +0100
+++ linux-2.6.32-rc4/drivers/usb/serial/ark3116.c 2009-10-28 10:19:48.000000000 +0100
@@ -113,45 +113,6 @@ static int ark3116_read_reg(struct usb_s
return buf[0];
}
-static inline void ARK3116_SND(struct usb_serial *serial, int seq,
- __u8 request, __u8 requesttype,
- __u16 value, __u16 index)
-{
- int result;
- result = usb_control_msg(serial->dev,
- usb_sndctrlpipe(serial->dev, 0),
- request, requesttype, value, index,
- NULL, 0x00, 1000);
- dbg("%03d > ok", seq);
-}
-
-static inline void ARK3116_RCV(struct usb_serial *serial, int seq,
- __u8 request, __u8 requesttype,
- __u16 value, __u16 index, __u8 expected,
- char *buf)
-{
- int result;
- result = usb_control_msg(serial->dev,
- usb_rcvctrlpipe(serial->dev, 0),
- request, requesttype, value, index,
- buf, 0x0000001, 1000);
- if (result)
- dbg("%03d < %d bytes [0x%02X]", seq, result,
- ((unsigned char *)buf)[0]);
- else
- dbg("%03d < 0 bytes", seq);
-}
-
-static inline void ARK3116_RCV_QUIET(struct usb_serial *serial,
- __u8 request, __u8 requesttype,
- __u16 value, __u16 index, char *buf)
-{
- usb_control_msg(serial->dev,
- usb_rcvctrlpipe(serial->dev, 0),
- request, requesttype, value, index,
- buf, 0x0000001, 1000);
-}
-
static inline int calc_divisor(int bps)
{
/* Original ark3116 made some exceptions in rounding here
--
next prev parent reply other threads:[~2009-10-28 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 9:43 [PATCH 0/6] ark3116: (v2) driver rework after review bart.hartgers
2009-10-28 9:43 ` [PATCH 1/6] ark3116: (v2) Setup some basic infrastructure for new ark3116 driver bart.hartgers
2009-10-28 9:43 ` [PATCH 2/6] ark3116: (v2) Make existing functions 16450-aware and add close and release functions bart.hartgers
2009-10-28 9:43 ` [PATCH 3/6] ark3116: (v2) Replace cmget bart.hartgers
2009-10-28 9:43 ` [PATCH 4/6] ark3116: (v2) Add cmset and break bart.hartgers
2009-10-28 9:43 ` [PATCH 5/6] ark3116: (v2) Callbacks for interrupt and bulk read bart.hartgers
2009-10-28 9:43 ` bart.hartgers [this message]
2009-10-28 11:41 ` [PATCH 0/6] ark3116: (v2) driver rework after review Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028095112.823213217@gmail.com \
--to=bart.hartgers@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox