Re: [PATCH 3/3] vmscan: Force kswapd to take notice faster when high-order watermarks are being hit

Frans Pop
2009-11-04T02:05:57Z

On Wednesday 04 November 2009, Mel Gorman wrote:
> > If you'd like me to test with the congestion_wait() revert on top of
> > this for comparison, please let me know.
>
> No, there is resistance to rolling back the congestion_wait() changes

I've never promoted the revert as a solution. It just shows the cause of a
regression.

> from what I gather because they were introduced for sane reasons. The
> consequence is just that the reliability of high-order atomics are
> impacted because more processes are making forward progress where
> previously they would have waited until kswapd had done work. Your
> driver has already been fixed in this regard and maybe it's a case that
> the other atomic users simply have to be fixed to "not do that".

The problem is that although my driver has been fixed so that it no longer
causes the SKB allocation errors, the also rather serious behavior change
where due to swapping my 3rd gitk takes up to twice as long to load with
desktop freezes of up 45 seconds or so is still there.

Although that's somewhat separate from the issue that started this whole
investigation, I still feel that should be sorted out as well.

The congestion_wait() change, even if theoretically valid, introduced a
very real regression IMO. Such long desktop freezes during swapping should
be avoided; .30 and earlier simply behaved a whole lot better in the same
situation.

Cheers,
FJP