public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <borislav.petkov@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, x86 <x86@kernel.org>
Cc: Doug Thompson <norsk5@yahoo.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [RFC] amd64_edac: syndromes loading
Date: Wed, 28 Oct 2009 17:35:34 +0100	[thread overview]
Message-ID: <20091028163534.GA625@aftab> (raw)

Hi,

I've been pondering how to avoid adding almost 15K of syndrome tables to
the edac driver.

The syndrome tables are used for mapping a correctable ECC to the
corresponding DIMM and thus pinpointing the DIMM about to fail. There
are two flavors of syndromes based on the ECCs: x4 and x8. The x4 table
of size 540 u16 values is already in the driver but the x8 is much
bigger (4864 u16) and I wouldn't want to add it statically into the
driver.

Rather, I'd like to dynamically load them depending on the DRAM
configuration of each node. The two attached patches do that using
the request_firmware() interface. This way, the syndrome tables could
be added as binary blobs in drivers/edac/ and then installed with
'make firmware_install'. This way we avoid polluting driver code with
humongous u16 arrays of ECC syndromes.

What do you guys think, could that be an acceptable approach? Any
suggestions/comments are welcome.

Thanks.

-- 
Regards/Gruss,
Boris.

Operating | Advanced Micro Devices GmbH
  System  | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
 Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
  Center  | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
  (OSRC)  | Registergericht München, HRB Nr. 43632


             reply	other threads:[~2009-10-28 16:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 16:35 Borislav Petkov [this message]
2009-10-28 16:37 ` [PATCH 1/2] amd64_edac: load syndrome table through firmware API Borislav Petkov
2009-10-28 16:38 ` [PATCH 2/2] amd64_edac: syndromes housekeeping Borislav Petkov
2009-10-28 17:15 ` [RFC] amd64_edac: syndromes loading Doug Thompson
2009-10-28 17:28   ` Borislav Petkov
2009-11-01 21:13     ` Pavel Machek
2009-11-01 22:33       ` H. Peter Anvin
2009-11-05 13:27         ` Borislav Petkov
2009-11-05 21:15           ` Doug Thompson
2009-11-05 22:17           ` Pavel Machek
2009-11-06 13:20             ` Borislav Petkov
2009-11-12 18:40               ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028163534.GA625@aftab \
    --to=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=norsk5@yahoo.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox