[PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[liu weni]

In the origin, the code notes are not fit for set_irq_msi.
I modify the code notes, and no any changes for the code.


diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index c166019..da2f254 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
 EXPORT_SYMBOL(set_irq_data);

 /**
- * set_irq_data - set irq type data for an irq
+ * set_irq_msi - set MSI descriptor data for an irq
  * @irq: Interrupt number
  * @entry: Pointer to MSI descriptor data
  *
- * Set the hardware irq controller data for an irq
+ * Set the MSI descriptor entry for an irq
  */
 int set_irq_msi(unsigned int irq, struct msi_desc *entry)
 {





Best Regards

Liuweni

Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for the function.

[Jiri Kosina]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 913 bytes --]

On Mon, 26 Oct 2009, liu weni wrote:

> In the origin, the code notes are not fit for set_irq_msi.
> I modify the code notes, and no any changes for the code.
> 
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..da2f254 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
> 
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
>  int set_irq_msi(unsigned int irq, struct msi_desc *entry)
>  {

Please send the patch with proper Signed-off-by: line so that I can queue 
it in my tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for thefunction.

[Liuweni]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1508 bytes --]

hi Jiri Kosina,

Thanks for your help. This is my first upload my patch.

I had repatched it to Linux kernel with Signed-off-by.
http://lkml.org/lkml/2009/10/28/12



Any problem, please let me kown. 

2009-10-28 

Best Regards
 
Liuweni
 



发件人： Jiri Kosina 
发送时间： 2009-10-27  20:53:43 
收件人： liu weni 
抄送： linux-kernel 
主题： Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for thefunction. 
 
On Mon, 26 Oct 2009, liu weni wrote:
> In the origin, the code notes are not fit for set_irq_msi.
> I modify the code notes, and no any changes for the code.
> 
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index c166019..da2f254 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -166,11 +166,11 @@ int set_irq_data(unsigned int irq, void *data)
>  EXPORT_SYMBOL(set_irq_data);
> 
>  /**
> - * set_irq_data - set irq type data for an irq
> + * set_irq_msi - set MSI descriptor data for an irq
>   * @irq: Interrupt number
>   * @entry: Pointer to MSI descriptor data
>   *
> - * Set the hardware irq controller data for an irq
> + * Set the MSI descriptor entry for an irq
>   */
>  int set_irq_msi(unsigned int irq, struct msi_desc *entry)
>  {
Please send the patch with proper Signed-off-by: line so that I can queue 
it in my tree.
Thanks,
-- 
Jiri Kosina
SUSE Labs, Novell Inc.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: Re: [PATCH]kernel/irq/chip.c:The code notes is not fit for thefunction.

[Jiri Kosina]

On Wed, 28 Oct 2009, Liuweni wrote:

> hi Jiri Kosina,
> 
> Thanks for your help. This is my first upload my patch.
> 
> I had repatched it to Linux kernel with Signed-off-by.
> http://lkml.org/lkml/2009/10/28/12
> 
> Any problem, please let me kown. 

In the future, please always send the patch (CC) to everyone interested, 
sending web links is usually not sufficient.

I have changed the changelog slightly, and applied your patch. Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.