Re: [PATCH] 3/3 staging: hv: fix oops in vmbus - missing #include

[Greg KH <gregkh@suse.de>]

On Wed, Oct 28, 2009 at 11:54:00PM +0100, Milan Dadok wrote:
> It's gentoo
> Primary I was working on linux-2.6.31-gentoo 
> gcc-config  -l
>  [1] i686-pc-linux-gnu-4.3.2 *
> 
> 10 Sep 2009; Mike Pagano <mpagano@gentoo.org>
>   +gentoo-sources-2.6.31.ebuild:
>   Initial 2.6.31 release including the fbcondecor patch,, a paoatch to
>   enable control of the unaligned access control policy from sysctl and a
>   patch for bad block relocation support for LiveCD users.
> 
> I already suspected some error on my side, therefor I installed vanilla
> 2.6.32-r5
> Because I cannot made it to compile without #include, I send third patch.
> 
> Now I tried it again - and it look like only #include in osd.h is missing.
> In ChannelMgmt.h is not ...
> 
> My error is (#include workqueue.h commented in osd.h)
> # make SUBDIR=drivers/staging/hv CONFIG_DEBUG_SECTION_MISMATCH=y modules
> 
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   SYMLINK include/asm -> include/asm-x86
>   CALL    scripts/checksyscalls.sh
>   CC [M]  drivers/staging/hv/blkvsc_drv.o
>   CC [M]  drivers/staging/hv/BlkVsc.o
> In file included from drivers/staging/hv/BlkVsc.c:24:
> drivers/staging/hv/osd.h:68: warning: 'struct workqueue_struct' declared
> inside parameter list
> drivers/staging/hv/osd.h:68: warning: its scope is only this definition or
> declaration, which is probably not what you want

Wierd.  Can you send me your .config file?  I can't duplicate this on
Linus's current git tree at all.

> PS. I have another error with 2.6.32-rc5 - if there is some WARNING mismatch
> in reference, then *.ko is not copied to
> /lib/modules/2.6.32-rc5/kernel/drivers/staging/hv/
> It is correct behaivour of kernel build system?
> 2.6.31 without warning always copied .ko files to /lib

I don't know, I think that means an error is happening somewhere else.

thanks,

greg k-h