From: Mike Hommey <mh@glandium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josef Bacik <josef@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Steven Whitehouse <swhiteho@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Eric Sandeen <sandeen@redhat.com>,
Josef Bacik <jbacik@redhat.com>, Mark Fasheh <mfasheh@suse.com>
Subject: Re: [PATCH] Fix generic_block_fiemap for files bigger than 4GB
Date: Thu, 29 Oct 2009 16:19:45 +0100 [thread overview]
Message-ID: <20091029151945.GA453@glandium.org> (raw)
In-Reply-To: <20091029081701.83249755.akpm@linux-foundation.org>
On Thu, Oct 29, 2009 at 08:17:01AM -0700, Andrew Morton wrote:
> > - struct buffer_head tmp;
> > - unsigned int start_blk;
> > - long long length = 0, map_len = 0;
> > + struct buffer_head map_bh;
> > + sector_t start_blk;
>
> And the bugfix is there.
>
> Has anyone actually tested this code on large files? Greater than 4G
> sectors and greater than 4G pages?
>
I tested my patch with 2TB sparse files that would fail without the patch.
I can give a try to Josef's patch if that's necessary.
Mike
prev parent reply other threads:[~2009-10-29 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 17:24 [PATCH] Fix generic_block_fiemap for files bigger than 4GB Mike Hommey
2009-10-29 6:00 ` Andrew Morton
2009-10-29 12:31 ` Josef Bacik
2009-10-29 12:40 ` Josef Bacik
2009-10-29 15:17 ` Andrew Morton
2009-10-29 15:19 ` Mike Hommey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029151945.GA453@glandium.org \
--to=mh@glandium.org \
--cc=akpm@linux-foundation.org \
--cc=jbacik@redhat.com \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=sandeen@redhat.com \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox