From: Matthew Wilcox <matthew@wil.cx>
To: Tejun Heo <teheo@suse.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix updating of named attribute groups
Date: Thu, 29 Oct 2009 10:19:08 -0600 [thread overview]
Message-ID: <20091029161907.GL10555@parisc-linux.org> (raw)
In-Reply-To: <4AE9BBC6.3070304@suse.de>
On Thu, Oct 29, 2009 at 04:59:02PM +0100, Tejun Heo wrote:
> Matthew Wilcox wrote:
> > + if (update) {
> > + sd = sysfs_get_dirent(kobj->sd, grp->name);
> > + if (!sd)
> > + return -ENOENT;
> > + } else {
> > + error = sysfs_create_subdir(kobj, grp->name, &sd);
> > + if (error)
> > + return error;
> > + sysfs_get(sd);
> > + }
> > + } else {
> > + sd = sysfs_get(kobj->sd);
> > + }
>
> nitpick: the last braces aren't necessary.
But are more aesthetically pleasing.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-10-29 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 5:47 [PATCH 0/3] Allow sysfs to be dynamically populated Matthew Wilcox
2009-10-20 5:49 ` [PATCH 1/3] Fix updating of named attribute groups Matthew Wilcox
2009-10-29 15:59 ` Tejun Heo
2009-10-29 16:19 ` Matthew Wilcox [this message]
2009-10-29 16:24 ` Tejun Heo
2009-10-20 5:50 ` [PATCH 2/3] Sysfs: Allow directories to be populated dynamically Matthew Wilcox
2009-10-29 16:20 ` Tejun Heo
2009-10-29 16:21 ` Matthew Wilcox
2009-10-29 16:28 ` Tejun Heo
2009-10-29 19:24 ` Matthew Wilcox
2009-10-30 10:17 ` Tejun Heo
2009-10-30 11:14 ` Matthew Wilcox
2009-10-30 16:06 ` Tejun Heo
2009-10-20 5:50 ` [PATCH 3/3] Expose MSI-X interrupts through a dynamically generated sysfs directory Matthew Wilcox
2009-10-20 8:14 ` Américo Wang
2009-10-20 8:26 ` Matthew Wilcox
2009-10-27 17:32 ` Greg KH
2009-10-20 5:52 ` [PATCH 0/3] Allow sysfs to be dynamically populated Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029161907.GL10555@parisc-linux.org \
--to=matthew@wil.cx \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=teheo@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox