Re: [PATCH 2/3] Sysfs: Allow directories to be populated dynamically

[Matthew Wilcox <matthew@wil.cx>]

On Thu, Oct 29, 2009 at 05:20:00PM +0100, Tejun Heo wrote:
> This will increase the size of struct sysfs_dirent by three pointers
> which is considerable.  Bloating the size of sysfs_dirent can waste
> large amount of memory on machines with a lot of disks.

No it won't.  It's in a union with sysfs_inode_attrs which contains a
struct iattr, which is at least 52 bytes.

> The implementation looks quite scary to me.  Is this the only way to
> do this?  It it because trying to create individual entries for msix
> will end up creating too many sysfs entries?  If so, how many are we
> talking about?

While that's the original motivation, shrinking the amount of memory
taken by sysfs overall is a worthwhile achievement, don't you think?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."