From: Alex Chiang <achiang@hp.com>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Chris Wright <chrisw@sous-sol.org>,
Matthew Wilcox <willy@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: remove pci_find_slot from PCI_LEGACY config description
Date: Mon, 2 Nov 2009 11:27:07 -0700 [thread overview]
Message-ID: <20091102182707.GD5525@ldl.fc.hp.com> (raw)
In-Reply-To: <20091102165608.GB20277@vespa.holoscopio.com>
* Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>:
> On Mon, Nov 02, 2009 at 04:49:01PM +0100, Jiri Kosina wrote:
> > On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
> >
> > > Commit 3b073eda has removed pci_find_slot, so there's no point in
> > > mentioning it in the config description as one of the deprecated APIs
> > > there are enabled by PCI_LEGACY and still used by some drivers.
> >
> > While you are at it, how about removing the references in
> > Documentation/PCI/pci.txt as well?
>
> I've hit them. But, on a first fast look, they seemed important
> historically. I will take a closer look and point that if it's proper or
> remove them entirely as you suggest.
I think you can safely remove the references to the APIs that are
no longer in the kernel at all, such as pci_find_slot(), etc.
On the other hand, if an interface is still there but deprecated,
you can leave it in Documentation/PCI/pci.txt.
Thanks,
/ac
next prev parent reply other threads:[~2009-11-02 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 19:46 [PATCH] pci: remove pci_find_slot from PCI_LEGACY config description Thadeu Lima de Souza Cascardo
2009-11-02 15:49 ` Jiri Kosina
2009-11-02 16:56 ` Thadeu Lima de Souza Cascardo
2009-11-02 18:27 ` Alex Chiang [this message]
2009-11-04 18:18 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102182707.GD5525@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=cascardo@holoscopio.com \
--cc=chrisw@sous-sol.org \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox