[PATCH v2 0/7] vsprintf: reduce code size and clean up

[PATCH v2 0/7] vsprintf: reduce code size and clean up

[André Goddard Rosa]

>From 584d9bfc7c1d41b76a05655b4562b98fcbef6ee4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Goddard=20Rosa?= <andre.goddard@gmail.com>
Date: Sun, 1 Nov 2009 15:10:31 -0200
Subject: [PATCH v2 0/7] vsprintf: reduce code size and clean up
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch reduces code size by 240 bytes on my Core 2 with gcc 4.4.1:
       text    data     bss     dec     hex filename
      15767       0       8   15775    3d9f lib/vsprintf.o-before
      15527       0       8   15535    3caf lib/vsprintf.o-after

and implements some cleanups.

Changelog:
    v2: addressed feedback from Frederic Weisbecker review (thanks!!)
and split into separate patches
    v1: original submission

André Goddard Rosa (7):
  vsprintf: factorize "(null)" string
  vsprintf: pre-calculate final string length
  vsprintf: give it some care to please checkpatch.pl
  vsprintf: use TOLOWER whenever possible
  vsprintf: reduce code size by avoiding extra check
  vsprintf: move local vars to block local vars and remove unneeded
    ones
  vsprintf: factor out skip_space code in a separate function

 lib/vsprintf.c |  306 ++++++++++++++++++++++++++++++--------------------------
 1 files changed, 163 insertions(+), 143 deletions(-)

Re: [PATCH v2 0/7] vsprintf: reduce code size and clean up

[Frederic Weisbecker]

On Mon, Nov 02, 2009 at 03:26:07PM -0200, André Goddard Rosa wrote:
> Subject: [PATCH v2 0/7] vsprintf: reduce code size and clean up
> 
> This patch reduces code size by 240 bytes on my Core 2 with gcc 4.4.1:
>        text    data     bss     dec     hex filename
>       15767       0       8   15775    3d9f lib/vsprintf.o-before
>       15527       0       8   15535    3caf lib/vsprintf.o-after
> 
> and implements some cleanups.
> 
> Changelog:
>     v2: addressed feedback from Frederic Weisbecker review (thanks!!)
> and split into separate patches
>     v1: original submission
> 
> André Goddard Rosa (7):
>   vsprintf: factorize "(null)" string
>   vsprintf: pre-calculate final string length
>   vsprintf: give it some care to please checkpatch.pl
>   vsprintf: use TOLOWER whenever possible
>   vsprintf: reduce code size by avoiding extra check
>   vsprintf: move local vars to block local vars and remove unneeded
>     ones
>   vsprintf: factor out skip_space code in a separate function
> 
>  lib/vsprintf.c |  306 ++++++++++++++++++++++++++++++--------------------------
>  1 files changed, 163 insertions(+), 143 deletions(-)


Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

But please add a more verbose changelog in the 5th as per Ingo's
request, and do the case statement merge I suggested in the 6th.

Thanks!