Re: [PATCH] x86: Make sure we also print a Code: line for show_regs()

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Mon, Nov 02, 2009 at 04:59:15PM -0800, Arjan van de Ven wrote:
>From c560acdd03d28d3dc55ed9c19d42d4567caab1d8 Mon Sep 17 00:00:00 2001
>From: Arjan van de Ven <arjan@linux.intel.com>
>Date: Mon, 2 Nov 2009 16:50:04 -0800
>Subject: [PATCH] x86: Make sure we also print a Code: line for show_regs()
>
>show_regs() is called as a mini BUG() equivalent in some places,
>specifically for the "scheduling while atomic" case.
>
>Unfortunately right now it does not print a Code: like unlike
>a real bug/oops.
>
>This patch changes the x86 implementation of show_regs() so that
>it calls the same function as oopses do to print the registers
>as well as the Code: line.
>
>Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

>---
> arch/x86/kernel/process_32.c |    2 +-
> arch/x86/kernel/process_64.c |    3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
>index f2cb086..b124f2f 100644
>--- a/arch/x86/kernel/process_32.c
>+++ b/arch/x86/kernel/process_32.c
>@@ -189,7 +189,7 @@ void __show_regs(struct pt_regs *regs, int all)
> 
> void show_regs(struct pt_regs *regs)
> {
>-	__show_regs(regs, 1);
>+	show_registers(regs);
> 	show_trace(NULL, regs, &regs->sp, regs->bp);
> }
> 
>diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
>index 959b062..e53e66f 100644
>--- a/arch/x86/kernel/process_64.c
>+++ b/arch/x86/kernel/process_64.c
>@@ -228,8 +228,7 @@ void __show_regs(struct pt_regs *regs, int all)
> 
> void show_regs(struct pt_regs *regs)
> {
>-	printk(KERN_INFO "CPU %d:", smp_processor_id());
>-	__show_regs(regs, 1);
>+	show_registers(regs);
> 	show_trace(NULL, regs, (void *)(regs + 1), regs->bp);
> }
> 
>-- 
>1.6.0.6
>
>
>
>-- 
>Arjan van de Ven 	Intel Open Source Technology Centre
>For development, discussion and tips for power savings, 
>visit http://www.lesswatts.org
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.