From: Arnd Bergmann <arnd@arndb.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ankit Jain <me@ankitjain.org>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Arnd Bergmann <arndbergmann@googlemail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] fs: add missing compat_ptr handling for FS_IOC_RESVSP ioctl
Date: Tue, 3 Nov 2009 12:32:12 +0100 [thread overview]
Message-ID: <200911031232.12245.arnd@arndb.de> (raw)
In-Reply-To: <20091103104532.GA19670@osiris.boeblingen.de.ibm.com>
On Tuesday 03 November 2009, Heiko Carstens wrote:
>
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> For FS_IOC_RESVSP and FS_IOC_RESVSP64 compat_sys_ioctl() uses its
> arg argument as a pointer to userspace. However it is missing a
> a call to compat_ptr() which will do a proper pointer conversion.
>
> This was introduced with 3e63cbb1 "fs: Add new pre-allocation ioctls
> to vfs for compatibility with legacy xfs ioctls".
>
> Cc: Ankit Jain <me@ankitjain.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Arnd Bergmann <arndbergmann@googlemail.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2009-11-03 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 10:45 [PATCH] fs: add missing compat_ptr handling for FS_IOC_RESVSP ioctl Heiko Carstens
2009-11-03 11:32 ` Arnd Bergmann [this message]
2009-11-03 14:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911031232.12245.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arndbergmann@googlemail.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@ankitjain.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox