Re: [PATCH 00/11] Sort out sdio_uart - stage two

Nicolas Pitre
2009-11-04T01:48:10Z

On Wed, 4 Nov 2009, Alan Cox wrote:

> > >From what I can see, sdio_uart_open() and sdio_uart_activate() are
> > called on the first cat invocation, and then sdio_uart_close() and
> > sdio_uart_shutdown() when cat is stopped with ^C. However neither
>
> I would have expected the cat to terminate when the port is unplugged
> (and the uart remove method called - doing a hangup)

That works fine... the first time only. After the card is inserted back
then -EIO is always returned on open() from user space, same thing as
subsequent open() after ^C.

> > sdio_uart_open() nor sdio_uart_activate() is ever called anymore with
> > any subsequent cat invocations until a reboot. Some upper layer must
> > have taken upon itself to return -EIO to user space.
>
> The first call into the driver is to sdio_uart_install which looks up the
> port from tty->index and would blow up if for some reason the get method
> failed.

Well, same issue: I see it being called the first time. No calls what
so ever afterward until the next reboot.

Nicolas