* [PATCH 6/14] cpumask: use cpu_online in kernel/perf_event.c
@ 2009-11-03 4:26 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2009-11-03 4:26 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel, Andrew Morton, Andrew Morton
Also, we want to check against nr_cpu_ids, not num_possible_cpus().
The latter works, but the correct bounds check is < nr_cpu_ids.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
To: Thomas Gleixner <tglx@linutronix.de>
---
kernel/perf_event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/perf_event.c b/kernel/perf_event.c
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -1596,7 +1596,7 @@ static struct perf_event_context *find_g
if (perf_paranoid_cpu() && !capable(CAP_SYS_ADMIN))
return ERR_PTR(-EACCES);
- if (cpu < 0 || cpu > num_possible_cpus())
+ if (cpu < 0 || cpu >= nr_cpu_ids)
return ERR_PTR(-EINVAL);
/*
@@ -1604,7 +1604,7 @@ static struct perf_event_context *find_g
* offline CPU and activate it when the CPU comes up, but
* that's for later.
*/
- if (!cpu_isset(cpu, cpu_online_map))
+ if (!cpu_online(cpu))
return ERR_PTR(-ENODEV);
cpuctx = &per_cpu(perf_cpu_context, cpu);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-03 4:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-03 4:26 [PATCH 6/14] cpumask: use cpu_online in kernel/perf_event.c Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox