* [PATCH] dst: Fix parentheses
@ 2009-11-03 22:48 Roel Kluin
2009-11-03 22:53 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: Roel Kluin @ 2009-11-03 22:48 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, Andrew Morton, LKML, zbr
`|' has a higher precedence than `?' so since MSG_WAITALL is
defined 0x100, MSG_MORE was always written to the msg_flag.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/staging/dst/state.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dst/state.c b/drivers/staging/dst/state.c
index d057e52..bccbd6d 100644
--- a/drivers/staging/dst/state.c
+++ b/drivers/staging/dst/state.c
@@ -121,7 +121,7 @@ int dst_data_send_header(struct socket *sock,
msg.msg_namelen = 0;
msg.msg_control = NULL;
msg.msg_controllen = 0;
- msg.msg_flags = MSG_WAITALL | (more)?MSG_MORE:0;
+ msg.msg_flags = MSG_WAITALL | (more ? MSG_MORE : 0);
err = kernel_sendmsg(sock, &msg, &iov, 1, iov.iov_len);
if (err != size) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dst: Fix parentheses
2009-11-03 22:48 [PATCH] dst: Fix parentheses Roel Kluin
@ 2009-11-03 22:53 ` Evgeniy Polyakov
2009-11-03 23:08 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Evgeniy Polyakov @ 2009-11-03 22:53 UTC (permalink / raw)
To: Roel Kluin; +Cc: Greg Kroah-Hartman, devel, Andrew Morton, LKML
On Tue, Nov 03, 2009 at 11:48:58PM +0100, Roel Kluin (roel.kluin@gmail.com) wrote:
> `|' has a higher precedence than `?' so since MSG_WAITALL is
> defined 0x100, MSG_MORE was always written to the msg_flag.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Looks good, thank you!
Andrew, please queue it into the appropriate tree.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dst: Fix parentheses
2009-11-03 22:53 ` Evgeniy Polyakov
@ 2009-11-03 23:08 ` Greg KH
2009-11-04 10:13 ` Evgeniy Polyakov
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2009-11-03 23:08 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Roel Kluin, devel, Andrew Morton, LKML
On Wed, Nov 04, 2009 at 01:53:43AM +0300, Evgeniy Polyakov wrote:
> On Tue, Nov 03, 2009 at 11:48:58PM +0100, Roel Kluin (roel.kluin@gmail.com) wrote:
> > `|' has a higher precedence than `?' so since MSG_WAITALL is
> > defined 0x100, MSG_MORE was always written to the msg_flag.
> >
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>
> Looks good, thank you!
> Andrew, please queue it into the appropriate tree.
That would be my tree, I'll do it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dst: Fix parentheses
2009-11-03 23:08 ` Greg KH
@ 2009-11-04 10:13 ` Evgeniy Polyakov
0 siblings, 0 replies; 4+ messages in thread
From: Evgeniy Polyakov @ 2009-11-04 10:13 UTC (permalink / raw)
To: Greg KH; +Cc: Roel Kluin, devel, Andrew Morton, LKML
On Tue, Nov 03, 2009 at 03:08:27PM -0800, Greg KH (gregkh@suse.de) wrote:
> > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> >
> > Looks good, thank you!
> > Andrew, please queue it into the appropriate tree.
>
> That would be my tree, I'll do it.
Ok, no problem. Thank you Greg.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-04 10:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-03 22:48 [PATCH] dst: Fix parentheses Roel Kluin
2009-11-03 22:53 ` Evgeniy Polyakov
2009-11-03 23:08 ` Greg KH
2009-11-04 10:13 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox