Re: [PATCH 35/41] rt2800: prepare for rt2800lib addition

Ivo van Doorn
2009-11-06T18:24:51Z

Hi,

> @@ -2644,6 +2658,8 @@ static int rt2800usb_probe_hw(struct rt2
> {
> int retval;
>
> + rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_USB);
> +
> rt2x00dev->priv = (void *)&rt2800usb_rt2800_ops;
>
> /*
>

Another afterthought, so perhaps you could make it an incremental patch.
Could you move the rt2x00_set_chip_intf() to rt2x00pci and rt2x00usb?
That way the field will be set automatically for all drivers early during probe.

Thanks,

Ivo