Re: [PATCH 23/41] rt2x00: add driver private field to struct rt2x00_dev

Ivo van Doorn
2009-11-06T18:22:22Z

On Friday 06 November 2009, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 05 November 2009 19:57:05 Ivo van Doorn wrote:
> > On Thursday 05 November 2009, Ivo van Doorn wrote:
> > > On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > > > Subject: [PATCH] rt2x00: add driver private field to struct rt2x00_dev
> > > >
> > > > Enhance rt2x00 infrastructure by adding driver specific field to
> > > > struct rt2x00_dev.
> > > >
> > > > The new field will be used by rt2800 drivers for chipset registers
> > > > access abstraction layer.
> > > >
> > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > >
> > > Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> >
> > Sorry I have a better idea, please the pointer into struct rt2x00_ops,
> > that way you can assign it statically like the rest of that structure.
> > That makes actually sense since all other function ops structures
> > are assigned like that as well.
>
> I thought about doing it this way initially but since:
>
> - rt2800_ops are used by rt2800 drivers only and rt2x00dev->priv can be
> reused by other drivers for different purposes
>
> - I couldn't come up with the good name for new rt2x00_ops field :)
>
> I decided on the more flexible IMO for the whole rt2x00 stack solution
> (however there is some minor difference between them that it can be
> changed if you feel strongly about it).

Ok, keep it as it is now.

Ivo