Re: [announce] new rt2800 drivers for Ralink wireless & project tree

Bartlomiej Zolnierkiewicz
2009-11-03T21:45:31Z

On Tuesday 03 November 2009 22:00:03 Ivo van Doorn wrote:
> On Tuesday 03 November 2009, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi,
> >
> > The following patch series (against wireless-next) addresses issues raised
> > during code review and subsequently rejected by rt2x00/wireless/networking
> > maintainers.
>
> Really stop reading only the half of emails, try reading it entirely (or at least don't
> stop at the second word in a sentence). It really starts the bug me to repeat
> myself over and over again because you refuse to read.
>
> Your comments during code review were ACCEPTED with the only remark that
> it shouldn't be done right here and now.

Please stop this bullshit. We have some standards for the upstream code
and by being maintainer you have to live up to this standards and make sure
that they are respected instead of watering them down yourself..

You were not interested even in fixing the headers duplication (it turned
out debugging scripts needed only 25 lines of code to be able to work with
fixed headers -- 25 LOC in bash scripts used only for debugging instead
of 1800 LOC of kernel code).

Also: I've mostly heard that I can fix the code myself. Which I did.

> > The rewrite was quite conservative and there is still a room for improvement
> > but it should serve as a good starting base for all future work on rt2800
> > drivers, and there is a lot to do there (both drivers are still practically
> > non-functional).
>
> Hence the reason I can use my rt2800usb device as long as I don't connect to
> a 11n AP. But since everybody in the world has 11n devices, the rt2800usb device
> is not capable of doing anything...

I use 11bg AP but mine rt2800usb device is RT3070 (which is quite popular
nowadays) and it simply doesn't even work with rt2800usb currently.

> > Comments and patches are welcomed.
> >
> >
> > The following changes since commit fa867e7355a1bdcd9bf7d55ebe9296f5b9c4028a:
> > Juuso Oikarinen (1):
> > wl1271: Generalize command response reading
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git rt2800
> >
> > Bartlomiej Zolnierkiewicz (40):
> > rt2800usb: fix rt2800usb_rfcsr_read()
> > rt2800pci: fix crypto in TX frame
> > rt2800pci: fix comment about register access
> > rt2800pci: fix comment about IV/EIV fields
> > rt2x00: fix rt2x00usb_register_read() comment
> > rt2800usb: use rt2x00usb_register_multiwrite() to set key entries
> [.. snip..]
> > rt2800usb: fix comments in rt2800usb.h
> > rt2800usb: add RXINFO_DESC_SIZE definition
> [..snip..]
> > rt2800: fix comments in rt2800.h
> [..snip..]
> > rt2x00: remove needless ifdefs from rt2x00leds.h
>
> These 10 patches look sane enough. Please send them as patch series
> to linux-wireless.

I'll re-post later whole patch series to linux-wireless to ease the review.

> > rt2x00: add support for different chipset interfaces
>
> Not needed, you can determine exactly what chipset you have
> by looking at the other fields. So extending the structure to
> repeat the same information isn't needed.

It is a better to have a single field always indicating this since:
- combining information from other fields is complex and error-prone
- the situation may change in the future

However I would love to be proven wrong with the patch.

> > MAINTAINERS: add rt2800 entry
>
> I see you decided to take over the maintainership?

This is my kernel tree after all. :)

> Doesn't that need the current maintainer to move away, or was this part
> of the "going over other peoples head" plan?

I just do what is the best to get working drivers in the foreseeable future.

--
Bartlomiej Zolnierkiewicz