Re: [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file.

Eric W. Biederman
2009-11-06T11:33:34Z

Christian Borntraeger <borntraeger@de.ibm.com> writes:

> Am Freitag 06 November 2009 01:41:44 schrieb Eric W. Biederman:
>> From: Eric W. Biederman <ebiederm@xmission.com>
>>
>> In preparation for more invasive cleanups separate the core
>> binary sysctl logic into it's own file.
>>
>> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
>
> Hmm, with your patches on Linus git I get the following on s390:
>
> kernel/sysctl_binary.c: In function 'SYSC_sysctl':
> kernel/sysctl_binary.c:126: error: implicit declaration of function
> 'lock_kernel'
> kernel/sysctl_binary.c:129: error: implicit declaration of function
> 'unlock_kernel'

Bah. A missing smp_lock.h.

Thanks.
Eric