From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: prevent build warning: 'ftrace_graph_buf' defined but not used
Date: Thu, 5 Nov 2009 07:39:19 +0100 [thread overview]
Message-ID: <20091105063917.GA4896@nowhere> (raw)
In-Reply-To: <4AF24381.5060307@cn.fujitsu.com>
On Thu, Nov 05, 2009 at 11:16:17AM +0800, Lai Jiangshan wrote:
>
> prevent build warning when !CONFIG_FUNCTION_GRAPH_TRACER
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 7cb6f19..892e3ea 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2274,7 +2274,6 @@ void ftrace_set_notrace(unsigned char *buf, int len, int reset)
> #define FTRACE_FILTER_SIZE COMMAND_LINE_SIZE
> static char ftrace_notrace_buf[FTRACE_FILTER_SIZE] __initdata;
> static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;
> -static char ftrace_graph_buf[FTRACE_FILTER_SIZE] __initdata;
>
> static int __init set_ftrace_notrace(char *str)
> {
> @@ -2291,6 +2290,7 @@ static int __init set_ftrace_filter(char *str)
> __setup("ftrace_filter=", set_ftrace_filter);
>
> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> +static char ftrace_graph_buf[FTRACE_FILTER_SIZE] __initdata;
> static int __init set_graph_function(char *str)
> {
> strlcpy(ftrace_graph_buf, str, FTRACE_FILTER_SIZE);
>
next prev parent reply other threads:[~2009-11-05 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 3:16 [PATCH] tracing: prevent build warning: 'ftrace_graph_buf' defined but not used Lai Jiangshan
2009-11-05 6:39 ` Frederic Weisbecker [this message]
2009-11-17 7:46 ` Lai Jiangshan
2009-11-17 13:37 ` Steven Rostedt
2009-11-17 15:07 ` Steven Rostedt
2009-11-18 11:13 ` [tip:tracing/core] tracing: Prevent " tip-bot for Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105063917.GA4896@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox