Re: [PATCH 4/6] hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf events

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Nov 05, 2009 at 10:03:36PM +1100, Paul Mackerras wrote:
> Frederic Weisbecker writes:
> 
> > @@ -207,6 +212,15 @@ struct perf_event_attr {
> >  		__u32		wakeup_events;	  /* wakeup every n events */
> >  		__u32		wakeup_watermark; /* bytes before wakeup   */
> >  	};
> > +
> > +	union {
> > +		struct { /* Hardware breakpoint info */
> > +			__u64		bp_addr;
> > +			__u32		bp_type;
> > +			__u32		bp_len;
> > +		};
> > +	};
> 
> I'm wondering why you don't use attr.config for anything with
> breakpoint events?
> 
> Paul.


Because this is not sufficient to host the breakpoint parameters
given from userspace. May be I'm missing something?