From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: dimm <dmitry.adamushko@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>, Mike Travis <travis@sgi.com>,
Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <borislav.petkov@amd.com>,
Andreas Mohr <andi@lisas.de>, Jack Steiner <steiner@sgi.com>
Subject: Re: [ RFC, PATCH - 1/2, v2 ] x86-microcode: refactor microcode output messages
Date: Thu, 5 Nov 2009 16:37:42 +0100 [thread overview]
Message-ID: <20091105153742.GA18592@alberich.amd.com> (raw)
In-Reply-To: <1257192496.5941.8.camel@dimm>
The patches don't properly work here.
(1) For instance I got following log entries when doing
suspend/resume, doing CPU offline/online test and reloading the
module:
microcode: original microcode versions...
microcode: CPU0-3: patch_level=0x1000065
platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
...
microcode: CPU0-1,3: patch_level=0x1000083
microcode: CPU2-3: patch_level=0x1000065
Microcode Update Driver: v2.00 <tigran@aivazian.fsnet.co.uk>, Peter Oruba
The patch levels are:
# for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
PATCH_LEVEL = 0x0000000001000083
PATCH_LEVEL = 0x0000000001000083
PATCH_LEVEL = 0x0000000001000065
PATCH_LEVEL = 0x0000000001000065
(2) During suspend/resume the ucode is not updated:
hadburg linux # for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
PATCH_LEVEL = 0x0000000001000083
PATCH_LEVEL = 0x0000000001000083
PATCH_LEVEL = 0x0000000001000083
PATCH_LEVEL = 0x0000000001000083
hadburg linux # pm-suspend
hadburg linux # for i in `seq 0 3`; do lsmsr -c $i PATCH_LEVEL; done
PATCH_LEVEL = 0x0000000001000065
PATCH_LEVEL = 0x0000000001000065
PATCH_LEVEL = 0x0000000001000065
PATCH_LEVEL = 0x0000000001000065
That used to work w/o your patches. Didn't have time to look why this
is now failing. You've changed mc_cpu_callback() -- most likely that
is causing this regression.
Regards,
Andreas
next prev parent reply other threads:[~2009-11-05 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 20:08 [ RFC, PATCH - 1/2, v2 ] x86-microcode: refactor microcode output messages dimm
2009-11-04 12:27 ` Ingo Molnar
2009-11-05 15:37 ` Andreas Herrmann [this message]
2009-11-05 18:40 ` Dmitry Adamushko
2009-11-06 12:34 ` Andreas Herrmann
2009-11-06 12:56 ` Dmitry Adamushko
2009-11-06 19:46 ` Andreas Herrmann
2009-11-07 12:22 ` Dmitry Adamushko
2009-11-11 16:07 ` Dmitry Adamushko
2009-11-11 19:38 ` Andreas Herrmann
2009-11-12 11:33 ` Ingo Molnar
2009-11-12 11:54 ` Dmitry Adamushko
2009-11-12 12:06 ` Dmitry Adamushko
2009-11-12 15:20 ` Andreas Herrmann
2009-11-12 15:48 ` Dmitry Adamushko
2009-11-12 17:09 ` Borislav Petkov
2009-11-17 7:06 ` [PATCH] x86, ucode-amd: Move family check to microcde_amd.c's init function Andreas Herrmann
2009-11-17 9:24 ` [tip:x86/microcode] x86: " tip-bot for Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105153742.GA18592@alberich.amd.com \
--to=herrmann.der.user@googlemail.com \
--cc=andi@lisas.de \
--cc=borislav.petkov@amd.com \
--cc=dmitry.adamushko@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox