Re: specjbb2005 and aim7 regression with 2.6.32-rc kernels

Peter Zijlstra
2009-11-09T09:15:13Z

On Mon, 2009-11-09 at 08:09 +0100, Mike Galbraith wrote:
> + smp_read_barrier_depends();
> cpumask_setall(cpus);
> + cpumask_and(cpus, cpus, cpu_online_mask);

how about: cpumask_copy(cpus, cpu_online_mask); ?

Also, iirc cpu_online_mask is guaranteed stable when preemption is
disabled, otherwise you need to use get/put_online_cpus(), an
rmb_depends() won't do.