From: Arnd Bergmann <arnd@arndb.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Kyle McMartin <kyle@mcmartin.ca>,
Thibaut Varene <T-Bone@parisc-linux.org>,
Carsten Otte <cotte@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/11] generic compat_sys_sysctl
Date: Fri, 6 Nov 2009 11:27:24 +0100 [thread overview]
Message-ID: <200911061127.25337.arnd@arndb.de> (raw)
In-Reply-To: <m1tyx8trik.fsf@fess.ebiederm.org>
On Friday 06 November 2009, Eric W. Biederman wrote:
> current architecture name for it's 32bit compat syscall with
> compat_sys_sysctl, and deleting the architectures private
> 32bit compat syscall. The only requirement is that CONFIG_COMPAT
> be set when you need compat_sys_sysctl.
>
> These patches should just work, but an eyeball from someone who is
> familiar with the architecture specific details would be appreciated.
> I have only tested the 32bit compat code on x86_64.
I have done similar conversions for other syscalls and am familiar
with s390 and powerpc specific details. Your compat code looks good
for all of the pitfalls I'm aware of and possibly fixes bugs in the
existing arch specific implementations.
Very nice series!
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2009-11-06 10:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 0:40 [PATCH 0/11] generic compat_sys_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file Eric W. Biederman
2009-11-06 9:04 ` Christian Borntraeger
2009-11-06 11:33 ` Eric W. Biederman
2009-11-06 12:10 ` Arnd Bergmann
2009-11-06 12:55 ` Eric W. Biederman
2009-11-06 13:11 ` Arnd Bergmann
2009-11-06 13:58 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 02/11] sysctl: Refactor the binary sysctl handling to remove duplicate code Eric W. Biederman
2009-11-06 0:41 ` [PATCH 03/11] sysctl: Introduce a generic compat sysctl sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 04/11] sysctl: ia64 Use the compat_sys_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 05/11] sysctl: mips " Eric W. Biederman
2009-11-06 0:41 ` [PATCH 06/11] sysctl: parisc " Eric W. Biederman
2009-11-06 6:01 ` Kyle McMartin
2009-11-06 0:41 ` [PATCH 07/11] sysctl: s390 " Eric W. Biederman
2009-11-06 9:12 ` Christian Borntraeger
2009-11-06 10:19 ` Eric W. Biederman
2009-11-06 9:23 ` Martin Schwidefsky
2009-11-06 0:41 ` [PATCH 08/11] sysctl: sparc " Eric W. Biederman
2009-11-06 1:42 ` David Miller
2009-11-06 0:41 ` [PATCH 09/11] sysctl: x86 " Eric W. Biederman
2009-11-06 0:56 ` H. Peter Anvin
2009-11-06 1:15 ` Eric W. Biederman
2009-11-06 0:41 ` [PATCH 10/11] sysctl: Remove the cond_syscall entry for sys32_sysctl Eric W. Biederman
2009-11-06 0:41 ` [PATCH 11/11] sysctl: Make do_sysctl static Eric W. Biederman
2009-11-06 0:48 ` [PATCH 0/11] generic compat_sys_sysctl Eric W. Biederman
2009-11-06 10:27 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911061127.25337.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=T-Bone@parisc-linux.org \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kyle@mcmartin.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox