From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
Containers <containers@lists.linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
hpa@zytor.com, Alexey Dobriyan <adobriyan@gmail.com>,
roland@redhat.com, Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [v11][PATCH 8/9] Define clone_with_pids() syscall
Date: Fri, 6 Nov 2009 12:02:10 -0600 [thread overview]
Message-ID: <20091106180210.GA31652@us.ibm.com> (raw)
In-Reply-To: <20091105054124.GH16142@us.ibm.com>
Quoting Sukadev Bhattiprolu (sukadev@us.ibm.com):
> + stack_size = (unsigned long)kca.child_stack_size;
> + child_stack = (unsigned long)kca.child_stack_base + stack_size;
> +
> + if (!child_stack)
> + child_stack = regs->sp;
I'm hooking up the s390 version right now. Do you think you should
make this
if (!kca.child_stack_base)
child_stack = regs->sp;
?
I suppose that in general if I pass in a NULL kca.child_stack_base
I'll also pass in a 0 stacksize, but as a user I'd expect that if
I pass in NULL, the size gets ignored. Instead, if I pass in NULL
plus a size, then the kernel will take (void *)size as the stacktop.
-serge
next prev parent reply other threads:[~2009-11-06 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 5:30 [v11][PATCH 0/9] Implement clone_with_pids() system call Sukadev Bhattiprolu
2009-11-05 5:36 ` [v11][PATCH 1/9] Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-11-05 5:37 ` [v11][PATCH 2/9] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-11-05 5:38 ` [v11][PATCH 3/9] Define set_pidmap() function Sukadev Bhattiprolu
2009-11-05 5:38 ` [v11][PATCH 4/9] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-11-05 5:39 ` [v11][PATCH 5/9] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-11-05 5:40 ` [v11][PATCH 6/9] Check invalid clone flags Sukadev Bhattiprolu
2009-11-05 5:40 ` [v11][PATCH 7/9] Define do_fork_with_pids() Sukadev Bhattiprolu
2009-11-05 5:41 ` [v11][PATCH 8/9] Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-11-06 18:02 ` Serge E. Hallyn [this message]
2009-11-07 20:18 ` Sukadev Bhattiprolu
2009-11-09 20:37 ` Serge E. Hallyn
2009-11-05 5:42 ` [v11][PATCH 9/9] Document " Sukadev Bhattiprolu
2009-11-06 18:39 ` Serge E. Hallyn
2009-11-06 20:18 ` Matt Helsley
2009-11-06 21:45 ` Matt Helsley
2009-11-07 2:26 ` Sukadev Bhattiprolu
2009-11-07 21:56 ` Oren Laadan
2009-11-08 15:09 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106180210.GA31652@us.ibm.com \
--to=serue@us.ibm.com \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=sukadev@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox