From: Greg KH <greg@kroah.com>
To: "Sebastian Dalfuß" <sd@sedf.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks
Date: Fri, 6 Nov 2009 14:59:31 -0800 [thread overview]
Message-ID: <20091106225931.GD32205@kroah.com> (raw)
In-Reply-To: <20091106134812.GA27210@sedf.de>
On Fri, Nov 06, 2009 at 02:48:12PM +0100, Sebastian Dalfuß wrote:
> From: Sebastian Dalfuß <sd@sedf.de>
>
> This patch is based on next-20091106.
> This patch reduces the number of exclamation marks in DBGPRINT() and
> printk() strings (also comments) to a slightly less insane number.
>
> Signed-off-by: Sebastian Dalfuß <sd@sedf.de>
> ---
> diff -ru b/drivers/staging/rt2860/common/cmm_data.c c/drivers/staging/rt2860/common/cmm_data.c
> --- b/drivers/staging/rt2860/common/cmm_data.c 2009-11-06 08:03:10.000000000 +0100
> +++ c/drivers/staging/rt2860/common/cmm_data.c 2009-11-06 12:04:42.201639959 +0100
> @@ -1729,7 +1729,7 @@
> pAd->MacTab.Size));
> } else {
> DBGPRINT(RT_DEBUG_OFF,
> - ("\n%s: Impossible Wcid = %d !!!!!\n",
> + ("\n%s: Impossible Wcid = %d !!!\n",
Heh, this is funny. How did you determine that 3 '!' is acceptable when
4 or 5 '!' are not?
As this is a pretty pointless patch, I'm not going to apply it.
thanks,
greg k-h
next prev parent reply other threads:[~2009-11-06 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 13:48 [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks Sebastian Dalfuß
2009-11-06 22:59 ` Greg KH [this message]
2009-11-07 16:31 ` Sebastian Dalfuß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106225931.GD32205@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sd@sedf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox