Re: [Patch 3/3 v2] staging: rt2860: reduce superfluous exclamation marks

Greg KH
2009-11-06T23:37:35Z

On Fri, Nov 06, 2009 at 02:48:12PM +0100, Sebastian Dalfuß wrote:
> From: Sebastian Dalfuß <sd@sedf.de>
>
> This patch is based on next-20091106.
> This patch reduces the number of exclamation marks in DBGPRINT() and
> printk() strings (also comments) to a slightly less insane number.
>
> Signed-off-by: Sebastian Dalfuß <sd@sedf.de>
> ---
> diff -ru b/drivers/staging/rt2860/common/cmm_data.c c/drivers/staging/rt2860/common/cmm_data.c
> --- b/drivers/staging/rt2860/common/cmm_data.c 2009-11-06 08:03:10.000000000 +0100
> +++ c/drivers/staging/rt2860/common/cmm_data.c 2009-11-06 12:04:42.201639959 +0100
> @@ -1729,7 +1729,7 @@
> pAd->MacTab.Size));
> } else {
> DBGPRINT(RT_DEBUG_OFF,
> - ("\n%s: Impossible Wcid = %d !!!!!\n",
> + ("\n%s: Impossible Wcid = %d !!!\n",

Heh, this is funny. How did you determine that 3 '!' is acceptable when
4 or 5 '!' are not?

As this is a pretty pointless patch, I'm not going to apply it.

thanks,

greg k-h