public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH -next] staging/wireless: don't build when NET etc. are not enabled
Date: Sat, 7 Nov 2009 18:32:05 -0500	[thread overview]
Message-ID: <20091107233204.GA26871@tuxdriver.com> (raw)
In-Reply-To: <4AF4B2B3.8020109@oracle.com>

I'd better take this one...

Thanks, Randy!

John

On Fri, Nov 06, 2009 at 03:35:15PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> These wireless drivers in staging could be built when
> CONFIG_NET=n, CONFIG_NETDEVICES=n, causing this build error:
> 
> net/wireless/wext-priv.c: In function 'ioctl_private_call':
> net/wireless/wext-priv.c:206: error: implicit declaration of function 'call_commit_handler'
> 
> due to faulty selects.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> ---
>  drivers/staging/arlan/Kconfig   |    2 +-
>  drivers/staging/netwave/Kconfig |    2 +-
>  drivers/staging/wavelan/Kconfig |    4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-next-20091106.orig/drivers/staging/arlan/Kconfig
> +++ linux-next-20091106/drivers/staging/arlan/Kconfig
> @@ -1,6 +1,6 @@
>  config ARLAN
>  	tristate "Aironet Arlan 655 & IC2200 DS support"
> -	depends on ISA && !64BIT
> +	depends on ISA && !64BIT && WLAN
>  	select WIRELESS_EXT
>  	---help---
>  	  Aironet makes Arlan, a class of wireless LAN adapters. These use the
> --- linux-next-20091106.orig/drivers/staging/netwave/Kconfig
> +++ linux-next-20091106/drivers/staging/netwave/Kconfig
> @@ -1,6 +1,6 @@
>  config PCMCIA_NETWAVE
>  	tristate "Xircom Netwave AirSurfer Pcmcia wireless support"
> -	depends on PCMCIA
> +	depends on PCMCIA && WLAN
>  	select WIRELESS_EXT
>  	select WEXT_PRIV
>  	help
> --- linux-next-20091106.orig/drivers/staging/wavelan/Kconfig
> +++ linux-next-20091106/drivers/staging/wavelan/Kconfig
> @@ -1,6 +1,6 @@
>  config WAVELAN
>  	tristate "AT&T/Lucent old WaveLAN & DEC RoamAbout DS ISA support"
> -	depends on ISA
> +	depends on ISA && WLAN
>  	select WIRELESS_EXT
>  	select WEXT_SPY
>  	select WEXT_PRIV
> @@ -25,7 +25,7 @@ config WAVELAN
>  
>  config PCMCIA_WAVELAN
>  	tristate "AT&T/Lucent old WaveLAN Pcmcia wireless support"
> -	depends on PCMCIA
> +	depends on PCMCIA && WLAN
>  	select WIRELESS_EXT
>  	select WEXT_SPY
>  	select WEXT_PRIV
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

      reply	other threads:[~2009-11-07 23:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06  7:13 linux-next: Tree for November 6 Stephen Rothwell
2009-11-06 23:33 ` [PATCH -next] kmemleak: fix kconfig for crc32 build error Randy Dunlap
2009-11-06 23:12   ` Catalin Marinas
2009-11-06 23:35 ` [PATCH -next] staging/wireless: don't build when NET etc. are not enabled Randy Dunlap
2009-11-07 23:32   ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091107233204.GA26871@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox