From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: sparclinux@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc,sparc64: replace parentheses in pmul()
Date: Sun, 08 Nov 2009 00:28:15 -0800 (PST) [thread overview]
Message-ID: <20091108.002815.06996631.davem@davemloft.net> (raw)
In-Reply-To: <4AF3000C.8080607@gmail.com>
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 05 Nov 2009 17:40:44 +0100
> `>>' has a higher precedence than `?' so src2 evaluated to
> either 16 or 0 dependent on the bits set in rs2.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/sparc/kernel/visemul.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I am not 100% sure that the code was incorrect, however, if it
> was intended I think it is a very strange way to write it.
Your fix is correct, thanks Roel!
I really need to write a testsuite for this VIS emulation code.
prev parent reply other threads:[~2009-11-08 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 16:40 [PATCH] sparc,sparc64: replace parentheses in pmul() Roel Kluin
2009-11-08 8:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108.002815.06996631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox