public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Aristeu Rozanski <aris@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Fr?d?ric Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: introduce NMI_AUTO as nmi_watchdog option
Date: Sun, 8 Nov 2009 09:57:48 +0100	[thread overview]
Message-ID: <20091108085748.GA13716@elte.hu> (raw)
In-Reply-To: <19186.44983.543376.657628@pilspetsen.it.uu.se>


* Mikael Pettersson <mikpe@it.uu.se> wrote:

> Ingo Molnar writes:
>  > > but that would work only for LAPIC. You're suggesting killing IOAPIC 
>  > > mode too?
>  > 
>  > Would it be a big loss, with all modern systems expected to have a 
>  > working lapic based NMI source?
> 
> The IOAPIC NMI uses a HW resource that is free and reliable, the LAPIC 
> NMI uses a HW resource that is neither free nor reliable (for that 
> application), and for which better applications exist. So I prefer the 
> IOAPIC NMI.

The IO-APIC based NMI watchdog is neither free nor reliable.

Firstly, when we use it we cripple dynticks/NOHZ.

Secondly, there's been cases where activating the IO-APIC NMI watchdog 
causes rare lockups. One of my testsystems is such - once every few 
dozen bootups it would hang hard with the IO-APIC NMI watchdog 
activated.

No other OS uses the IO-APIC in this fashion, so it's a cute legacy 
hack, but we are phasing it out. It's not default.

> (I admit part of that preference is because using the IOAPIC NMI 
> helped stabilize a Dell PE2650 here years ago. Without the IOAPIC NMI 
> the machine would lock up hard within days or a few weeks at the 
> most.)

That looks quite myserious, did you get to the bottom of it? Does it 
reproduce with latest kernels too? It might be one of the dynticks hangs 
we fixed, and such hangs got in essence worked around by the nmi 
watchdog deactivating nohz. The nohz=off boot option would do something 
similar.

	Ingo

  reply	other threads:[~2009-11-08  8:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 17:10 [PATCH 2/2] x86: introduce NMI_AUTO as nmi_watchdog option Aristeu Rozanski
2009-11-04 11:46 ` Ingo Molnar
2009-11-04 12:33   ` Valdis.Kletnieks
2009-11-04 17:42     ` Ingo Molnar
2009-11-04 15:19   ` Aristeu Rozanski
2009-11-04 15:56     ` Ingo Molnar
2009-11-05 10:57       ` Mikael Pettersson
2009-11-08  8:57         ` Ingo Molnar [this message]
2009-11-09 20:02       ` Aristeu Rozanski
2009-11-10  5:20         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091108085748.GA13716@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aris@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox