public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
	tglx@linutronix.de, a.p.zijlstra@chello.nl, efault@gmx.de,
	acme@redhat.com, fweisbec@gmail.com
Subject: Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf.
Date: Sun, 8 Nov 2009 12:30:13 +0100	[thread overview]
Message-ID: <20091108113013.GM11372@elte.hu> (raw)
In-Reply-To: <20091104.194108.635980116686317754.mitake@dcl.info.waseda.ac.jp>


* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Subject: Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf.
> Date: Tue, 3 Nov 2009 18:29:26 +0100
> 
> > 
> > * Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> > 
> > > 
> > > Adding general performance benchmarking subcommand to perf.
> > > This patch adds bench/sched-pipe.c.
> > > 
> > > bench/sched-pipe.c is a benchmark program
> > > to measure performance of pipe() system call.
> > > This benchmark is based on pipe-test-1m.c by Ingo Molnar.
> > > http://people.redhat.com/mingo/cfs-scheduler/tools/pipe-test-1m.c
> > > 
> > > Example of use:
> > > % perf bench sched pipe               # Use default options
> > > 4.575  	     	   		      # Result is time
> > > % perf bench sched pipe -l 2000	      # This option means "loop 2000 counts"
> > > 0.024
> > 
> > ok, -l makes sense.
> > 
> > Shouldnt we output the unit of measurement, i.e. '4.575 usecs'? Also, we 
> > should perhaps print something like:
> > 
> >   % perf bench sched pipe
> > 
> >   (executing 1000000 pipe operations between two tasks)
> > 
> >      4.575 usecs per op
> >     218579 ops/sec   
> > 
> > ?
> 
> I have to admit that single float value output is too simple.
> So I'll fix the default output.
> 
> But, I believe that simple form makes sense for
> processing by scripts or graph tools like gnuplot.
> I'll add the option (may be --simple) to switch
> friendliness of outputs.

Btw., could you make it Git-ish, i.e.:

 --format=short

or:

 --format=simple

Eventually more format options might be added.

	Ingo

  reply	other threads:[~2009-11-08 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 10:55 [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf Hitoshi Mitake
2009-11-03 17:29 ` Ingo Molnar
2009-11-04 10:41   ` Hitoshi Mitake
2009-11-08 11:30     ` Ingo Molnar [this message]
2009-11-09  3:27       ` Hitoshi Mitake
2009-11-09  7:55         ` Ingo Molnar
2009-11-09 16:50           ` Hitoshi Mitake
2009-11-10  5:19             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091108113013.GM11372@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox