From: Ingo Molnar <mingo@elte.hu>
To: Ralf R??sch <ralf.roesch@rw-gmbh.de>
Cc: a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org,
hpa@zytor.com, mingo@redhat.com,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: sched: fix for non SMP systems in sched.h
Date: Sun, 8 Nov 2009 12:52:56 +0100 [thread overview]
Message-ID: <20091108115256.GR11372@elte.hu> (raw)
In-Reply-To: <4AEAF987.2080809@rw-gmbh.de>
* Ralf R??sch <ralf.roesch@rw-gmbh.de> wrote:
> commit d65d153bc23b84e4709a49137a9a03ae139d51a0 introduced
> two new prototypes: default_scale_freq_power and default_scale_smt_power.
> Both of them use struct sched_domain which is not defined on non SMP
> systems.
> Just moved the prototypes to the correct place.
>
> Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de>
> ---
> include/linux/sched.h | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
> mode change 100644 => 100755 include/linux/sched.h
>
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> old mode 100644
> new mode 100755
> index c231a24..b633308
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -1036,6 +1036,9 @@ static inline int test_sd_parent(struct
> sched_domain *sd, int flag)
> return 0;
> }
>
> +unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> +unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> +
> #else /* CONFIG_SMP */
>
> struct sched_domain_attr;
> @@ -1047,10 +1050,6 @@ partition_sched_domains(int ndoms_new, struct
> cpumask *doms_new,
> }
> #endif /* !CONFIG_SMP */
>
> -
> -unsigned long default_scale_freq_power(struct sched_domain *sd, int cpu);
> -unsigned long default_scale_smt_power(struct sched_domain *sd, int cpu);
> -
> struct io_context; /* See blkdev.h */
FYI, your patch has tabs converted to spaces (and line-wrap problems),
so it wont apply cleanly.
See Documentation/email-clients.txt about how to send patches without
such problems.
Thanks,
Ingo
prev parent reply other threads:[~2009-11-08 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 14:34 [PATCH] x86: sched: fix for non SMP systems in sched.h Ralf Rösch
2009-11-08 11:52 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108115256.GR11372@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ralf.roesch@rw-gmbh.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox