From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbZKHNdF (ORCPT ); Sun, 8 Nov 2009 08:33:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752604AbZKHNdE (ORCPT ); Sun, 8 Nov 2009 08:33:04 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:36375 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbZKHNdD (ORCPT ); Sun, 8 Nov 2009 08:33:03 -0500 Date: Sun, 8 Nov 2009 14:32:47 +0100 From: Ingo Molnar To: Cyrill Gorcunov Cc: Stephen Rothwell , Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: tip tree build warning Message-ID: <20091108133247.GA14807@elte.hu> References: <20091028181443.50a09dbb.sfr@canb.auug.org.au> <20091028073145.GD6353@elte.hu> <20091028184126.b5f52d1b.sfr@canb.auug.org.au> <20091028184851.504752ef.sfr@canb.auug.org.au> <20091028075012.GD19402@elte.hu> <20091108131645.GD5300@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091108131645.GD5300@lenovo> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=none autolearn=no SpamAssassin version=3.2.5 _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Cyrill Gorcunov wrote: > [Ingo Molnar - Wed, Oct 28, 2009 at 08:50:12AM +0100] > | > | * Stephen Rothwell wrote: > | > | > Hi all, > | > > | > On Wed, 28 Oct 2009 18:41:26 +1100 Stephen Rothwell wrote: > | > > > | > > static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid) > | > > { > | > > return physid_mask_of_physid(phys_apicid); > | > > } > | > > | > I just noticed that this function (default_apicid_to_cpu_present) is > | > declared "static inline in a header" but looks like it is only used by > | > assigning its address to a function pointer. Its only use for x86_64 > | > is in arch/x86/kernel/apic/apic_noop.c ... > | > | yes, that might be a real problem - returning the mask like that is > | messy. Thanks, will check. > | > | Ingo > | > > Darn, my fault sorry! Here is an update which fixes the issue. > (Btw, Stephen could you CC me next time if you get commit id > with me in authors, so I wouldn't miss problem). > > Please review, comments/complains are quite welcome! > > -- Cyrill > --- > x86,apic: Get rid of apicid_to_cpu_present assign on X86-64 > > In fact it's never get used on x86-64 (for 64 bit platform > we use differ technique to enumerate io-units). > > Signed-off-by: Cyrill Gorcunov > --- > arch/x86/kernel/apic/apic_noop.c | 5 +++++ > 1 file changed, 5 insertions(+) > > Index: linux-2.6.git/arch/x86/kernel/apic/apic_noop.c > ===================================================================== > --- linux-2.6.git.orig/arch/x86/kernel/apic/apic_noop.c > +++ linux-2.6.git/arch/x86/kernel/apic/apic_noop.c > @@ -162,7 +162,12 @@ struct apic apic_noop = { > > .cpu_to_logical_apicid = noop_cpu_to_logical_apicid, > .cpu_present_to_apicid = default_cpu_present_to_apicid, > + > +#ifdef CONFIG_X86_32 > .apicid_to_cpu_present = default_apicid_to_cpu_present, > +#else > + .apicid_to_cpu_present = NULL, > +#endif would be better to unify this instead ... Ingo