From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
x86team <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -tip] x86,apic: Use PAGE_SIZE instead of numbers
Date: Sun, 8 Nov 2009 18:53:56 +0300 [thread overview]
Message-ID: <20091108155356.GB25940@lenovo> (raw)
The whole page is reserved for IO-APIC fixmap
due to non-cacheable requirement. So lets note
this explicitly instead of playing with numbers.
CC: Yinghai Lu <yinghai@kernel.org>
CC: "Maciej W. Rozycki" <macro@linux-mips.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
Perhaps I miss something and (4 * 1024) have some special
meaning?
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/arch/x86/kernel/apic/io_apic.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6.git/arch/x86/kernel/apic/io_apic.c
@@ -4144,7 +4144,7 @@ fake_ioapic_page:
idx++;
ioapic_res->start = ioapic_phys;
- ioapic_res->end = ioapic_phys + (4 * 1024) - 1;
+ ioapic_res->end = ioapic_phys + PAGE_SIZE - 1;
ioapic_res++;
}
}
next reply other threads:[~2009-11-08 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 15:53 Cyrill Gorcunov [this message]
2009-11-08 16:09 ` [tip:x86/apic] x86, apic: Use PAGE_SIZE instead of numbers tip-bot for Cyrill Gorcunov
2009-11-08 17:28 ` [PATCH -tip] x86,apic: " Maciej W. Rozycki
2009-11-08 17:36 ` Cyrill Gorcunov
2009-11-08 18:03 ` Ingo Molnar
2009-11-09 23:07 ` H. Peter Anvin
2009-11-10 0:15 ` Maciej W. Rozycki
2009-11-10 4:40 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091108155356.GB25940@lenovo \
--to=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox