From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: linux-next: tip tree build warning
Date: Mon, 9 Nov 2009 09:10:38 +0100 [thread overview]
Message-ID: <20091109081038.GJ453@elte.hu> (raw)
In-Reply-To: <20091108213055.GA13555@lenovo>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> +++ linux-2.6.git/arch/x86/include/asm/apic.h
> @@ -310,7 +310,7 @@ struct apic {
> int (*apicid_to_node)(int logical_apicid);
> int (*cpu_to_logical_apicid)(int cpu);
> int (*cpu_present_to_apicid)(int mps_cpu);
> - physid_mask_t (*apicid_to_cpu_present)(int phys_apicid);
> + void (*apicid_to_cpu_present)(int phys_apicid, physid_mask_t *map);
Yep, passing masks by reference is unconditonal goodness - that's the
cleanup we want.
Mind sending a delta patch against tip:master?
Ingo
next prev parent reply other threads:[~2009-11-09 8:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 7:14 linux-next: tip tree build warning Stephen Rothwell
2009-10-28 7:31 ` Ingo Molnar
2009-10-28 7:41 ` Stephen Rothwell
2009-10-28 7:48 ` Stephen Rothwell
2009-10-28 7:50 ` Ingo Molnar
2009-11-08 13:16 ` Cyrill Gorcunov
2009-11-08 13:32 ` Ingo Molnar
2009-11-08 13:43 ` Cyrill Gorcunov
2009-11-08 18:42 ` Cyrill Gorcunov
2009-11-08 23:39 ` Stephen Rothwell
2009-11-09 9:27 ` [tip:x86/apic] x86, apic: Get rid of apicid_to_cpu_present assign on 64-bit tip-bot for Cyrill Gorcunov
2009-11-08 21:30 ` linux-next: tip tree build warning Cyrill Gorcunov
2009-11-09 8:10 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-01 7:22 Stephen Rothwell
2010-02-01 7:12 Stephen Rothwell
2009-12-30 23:45 Stephen Rothwell
2009-12-11 4:38 Stephen Rothwell
2009-11-25 10:53 Stephen Rothwell
2009-11-25 12:28 ` Frederic Weisbecker
2009-11-16 5:25 Stephen Rothwell
2009-11-16 17:05 ` Randy Dunlap
2009-11-23 18:05 ` Randy Dunlap
2009-10-13 3:42 Stephen Rothwell
2009-09-11 8:56 Stephen Rothwell
2009-09-13 20:20 ` Geert Uytterhoeven
2009-08-04 6:16 Stephen Rothwell
2009-08-04 16:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109081038.GJ453@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox