From: Jens Axboe <jens.axboe@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tejun Heo <tj@kernel.org>, Jiri Kosina <jkosina@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
cl@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: irq lock inversion
Date: Mon, 9 Nov 2009 16:34:18 +0100 [thread overview]
Message-ID: <20091109153418.GX8742@kernel.dk> (raw)
In-Reply-To: <20091108093859.GA2845@elte.hu>
On Sun, Nov 08 2009, Ingo Molnar wrote:
>
> * Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > On Fri, Nov 06 2009, Ingo Molnar wrote:
> > > Read the lockdep message please, consider all the backtraces it prints,
> > > it says something different.
> >
> > In all honesty, reading and parsing lockdep messages requires a
> > special state of mind. IOW, readability is not its high point.
>
> We frequently do patches to improve the messages but there's a hard
> limit: generally the messages mirror the complexity of the underlying
> locking scenario.
>
> Unfortunately lockdep cannot pretend something is simple when it is not.
> There are two ways out of that: either to simplify the underlying
> locking rules, or to understand them.
I think the primary problem is that it tries to condense too much
information, instead of just spelling it out. That may be obvious to a
person intimately familiar with lockdep, but not to others. Things like
the STATE line, for instance. It would read a lot easier if these things
were just spelled out.
I know this message isn't really productive, just tossing it out there.
I'll try to to back it up with a patch the next time it annoys me :-)
--
Jens Axboe
next prev parent reply other threads:[~2009-11-09 15:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86802c440911041008q4969b9bdk15b4598c40bb84bd@mail.gmail.com>
[not found] ` <4AF25FC7.4000502@kernel.org>
[not found] ` <20091105082102.GA2870@elte.hu>
[not found] ` <4AF28D7A.6020209@kernel.org>
2009-11-05 14:31 ` irq lock inversion Jiri Kosina
2009-11-06 5:53 ` Tejun Heo
2009-11-06 7:17 ` Ingo Molnar
2009-11-06 7:45 ` Tejun Heo
2009-11-06 7:58 ` Ingo Molnar
2009-11-06 8:24 ` Tejun Heo
2009-11-06 8:40 ` Ingo Molnar
2009-11-06 8:52 ` Tejun Heo
2009-11-06 16:08 ` Christoph Lameter
2009-11-06 16:38 ` Tejun Heo
2009-11-06 17:03 ` Christoph Lameter
2009-11-07 16:13 ` Peter Zijlstra
2009-11-09 5:46 ` [PATCH percpu#for-linus] percpu: fix possible deadlock via " Tejun Heo
2009-11-06 9:59 ` Jens Axboe
2009-11-08 9:38 ` Ingo Molnar
2009-11-09 15:34 ` Jens Axboe [this message]
2009-11-09 15:45 ` Ingo Molnar
2009-11-09 15:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109153418.GX8742@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=cl@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox