The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Darren Salt <linux@youmustbejoking.demon.co.uk>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rt28x0: remove no longer needed common/cmm_data_2860.c
Date: Mon, 9 Nov 2009 21:06:32 +0100	[thread overview]
Message-ID: <200911092106.32462.bzolnier@gmail.com> (raw)
In-Reply-To: <50BD09C528%linux@youmustbejoking.demon.co.uk>

On Monday 09 November 2009 18:54:38 Darren Salt wrote:
> Your removal of cmm_data_2860.c also removes a bug fix (commit
> 0af49167b1e5ba154e90d2c454bf4624ee47df80; for background, see
> http://bugzilla.kernel.org/show_bug.cgi?id=13390).

commit 0af49167b1e5ba154e90d2c454bf4624ee47df80
Author: Darren Salt <linux@youmustbejoking.demon.co.uk>
Date:   Wed Oct 14 02:19:22 2009 +0100

    Staging: rt2860sta: prevent a panic when disabling when associated

while:

ommit 5d315c4baa7be30e0fb8c924a64406492b2263b8
Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date:   Tue Sep 22 20:44:07 2009 +0200

    Staging: rt28x0: updates from vendor's V2.1.0.0 drivers

dropped cmm_data_2860.o from the build..

This must be one "lucky" bug looking at how things went subtly wrong
few times..  Pretty amazing..

> Is this fix present (or, better, not needed) in the code which obsoletes this
> file? (I can test if needed; just point me in the right direction wrt patches
> or repositories.)

It seems it is still needed so could you port it over to cmm_data_pci.c
(just use staging or linux-next as a base)?

Thanks.
-- 
Bartlomiej Zolnierkiewicz

  reply	other threads:[~2009-11-09 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 16:20 [PATCH] Staging: rt28x0: remove no longer needed common/cmm_data_2860.c Bartlomiej Zolnierkiewicz
2009-11-09 17:54 ` Darren Salt
2009-11-09 20:06   ` Bartlomiej Zolnierkiewicz [this message]
2009-11-09 22:59     ` Darren Salt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911092106.32462.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@youmustbejoking.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox