From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic: Do not use stacked physid_mask_t
Date: Tue, 10 Nov 2009 05:53:22 +0100 [thread overview]
Message-ID: <20091110045322.GC7897@elte.hu> (raw)
In-Reply-To: <20091109220659.GA5568@lenovo>
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> Hi all,
>
> during the conversation about physid_mask_t passed
> via stack
>
> http://lkml.org/lkml/2009/11/8/139
> http://lkml.org/lkml/2009/11/8/244
> http://lkml.org/lkml/2009/11/9/43
>
> the idea of moving masks via pointers not just for
> x86-64 (we even don't use those masks there but still
> have function declarations in struct apic) but for x86-32
> as well (ie more naturally -- as we operate with "struct cpumask")
> found to be usefull.
>
> As a result -- the following patch. Note that it's
> big enough and though I was trying to be carefull
> I would really appreciate more detailed review and
> comments and _complains_ as well.
No complaints from me - this is the cleanup i was striving for. Will let
you know if i see any test failures.
Thanks,
Ingo
next prev parent reply other threads:[~2009-11-10 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 22:06 [RFC -tip] x86,apic: Do not use stacked physid_mask_t Cyrill Gorcunov
2009-11-10 4:53 ` Ingo Molnar [this message]
2009-11-10 5:15 ` [tip:x86/apic] x86: apic: " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110045322.GC7897@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox