From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
gregkh@suse.de, KMoorman@transy.edu, w.sang@pengutronix.de,
ken_kawasaki@spring.nifty.jp, davem@davemloft.net,
Andrew Morton <akpm@osdl.org>,
alan@lxorguk.ukuu.org.uk
Subject: serial_cs: oxsemi quirk breaks resume
Date: Tue, 10 Nov 2009 08:54:11 +0100 [thread overview]
Message-ID: <20091110075410.GA6157@ucw.cz> (raw)
Quirk is applied on all cards with given manfid (is it that
correct?). Unfortunately, that quirk breaks resume on zaurus with
billionton bluetooth card inserted: c950ctrl is 0 and outb() faults.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
--- a/drivers/serial/serial_cs.c 2009-10-06 13:51:46.000000000 +0200
+++ b/drivers/serial/serial_cs.c 2009-11-09 14:43:25.000000000 +0100
@@ -158,7 +158,8 @@
{
struct serial_info *info = link->priv;
- outb(12, info->c950ctrl + 1);
+ if (info->c950ctrl)
+ outb(12, info->c950ctrl + 1);
}
/* request_region? oxsemi branch does no request_region too... */
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2009-11-10 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 7:54 Pavel Machek [this message]
2009-11-10 10:32 ` serial_cs: oxsemi quirk breaks resume Alan Cox
2009-11-10 10:53 ` Pavel Machek
2010-01-15 20:01 ` Pavel Machek
2010-01-15 23:53 ` Greg KH
2010-01-15 23:54 ` Greg KH
2010-01-16 7:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110075410.GA6157@ucw.cz \
--to=pavel@ucw.cz \
--cc=KMoorman@transy.edu \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=ken_kawasaki@spring.nifty.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox