From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
linux-kernel@vger.kernel.org,
virtualization@linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication
Date: Tue, 10 Nov 2009 12:49:14 +1030 [thread overview]
Message-ID: <200911101249.14390.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091109120839.GA11256@amit-x200.redhat.com>
On Mon, 9 Nov 2009 10:38:39 pm Amit Shah wrote:
> > 3) Don't use list_for_each_safe() to get the head entry of a list. Your
> > use is buggy anyway: buf will never be NULL afterwards.
>
> As long as 'head' isn't the only node in the list we should loop. And
> list_foreach_safe() does that. So it's OK right?
If there's more than one, buf will be == head.
> I'm sorry for having created more work for you; I'll send out my patches
> to you in a couple of days.
I spent some time on the weekend creating patches. They're not finished,
but they start the process of maturing the driver to where it can handle
multiple ports.
The next step is real buffer management (ie. the infrastructure for more than
one in flight, even though the normal console won't do this), then adding
headers.
I will post them now so you can take a look...
Rusty.
next prev parent reply other threads:[~2009-11-10 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 16:38 [PATCH v10 0/1] virtio-console: Support for generic ports and multiple consoles Amit Shah
2009-11-03 16:38 ` [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication Amit Shah
2009-11-06 7:10 ` Rusty Russell
2009-11-06 8:00 ` Christian Borntraeger
2009-11-06 13:00 ` Anthony Liguori
2009-11-06 14:12 ` Christian Borntraeger
2009-11-06 14:32 ` Anthony Liguori
2009-11-09 12:08 ` Amit Shah
2009-11-10 2:19 ` Rusty Russell [this message]
2009-11-06 7:43 ` Christian Borntraeger
2009-11-09 12:09 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911101249.14390.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox