From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755366AbZKJCUR (ORCPT ); Mon, 9 Nov 2009 21:20:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753056AbZKJCUQ (ORCPT ); Mon, 9 Nov 2009 21:20:16 -0500 Received: from ozlabs.org ([203.10.76.45]:42588 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbZKJCUP (ORCPT ); Mon, 9 Nov 2009 21:20:15 -0500 From: Rusty Russell To: Stephen Rothwell Subject: Re: linux-next: rr tree build warnings Date: Tue, 10 Nov 2009 12:50:17 +1030 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; i686; ; ) Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org References: <20091109183104.2bf7add6.sfr@canb.auug.org.au> In-Reply-To: <20091109183104.2bf7add6.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200911101250.17208.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2009 06:01:04 pm Stephen Rothwell wrote: > Hi Rusty, > > Today's linux-next build (x86_64 allmodconfig) produced these warnings: > > drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)' > drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)' > drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)' > drivers/usb/storage/libusual.c:239: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)' > > Introduced by commit 9f94999724555729819ea0143eab1d0529c029d1 > ("param:param_ops"). Thanks Stephen! Overzealous conversion; harmless but annoying. I've fixed this properly now... Rusty.