public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 2/2] regulator/mc13783: various cleanups
Date: Tue, 10 Nov 2009 13:08:49 +0000	[thread overview]
Message-ID: <20091110130849.GE16200@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1257841087-23662-2-git-send-email-u.kleine-koenig@pengutronix.de>

On Tue, Nov 10, 2009 at 09:18:07AM +0100, Uwe Kleine-König wrote:
> - define needed registers and bits in the driver
> - properly namespace functions and structs
> - fix locking as required by patch
>   "mfd/mc13783: near complete rewrite"
> - use platform_data as provided by "mfd/mc13783: near complete rewrite"
>   instead of accessing struct mc13783
> - struct mc13783_regulator_priv.desc is (and was) unused and so can go
>   away
> - use cpp magic to initialize mc13783_regulators
> - bring MODULE_LICENSE in sync with actual copyright
> - minor style fixes
> 
> This allows not including mc13783-private.h which I intend to remove
> soon.

Acked-by: Mark Brown <broonie@opensoruce.wolfsonmicro.com>

It'd have been a bit easier to review if done as more patches - eg, the
change to use macros to define the regulators could've been done as a
separate patch.

  reply	other threads:[~2009-11-10 13:08 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23 20:38 [PATCH] mfd/mc13783: near complete rewrite Uwe Kleine-König
2009-10-24  8:35 ` [PATCH] [RTC] Add Freescale MC13783 RTC driver Uwe Kleine-König
2009-11-01 20:34   ` Uwe Kleine-König
2009-11-04 18:12     ` Valentin Longchamp
2009-11-05 15:06       ` Valentin Longchamp
2009-11-10  8:32         ` [PATCH RESENT] " Uwe Kleine-König
2009-11-10  9:30           ` Alessandro Zummo
2009-11-10 11:10             ` Uwe Kleine-König
2009-11-22 21:49               ` Uwe Kleine-König
2009-11-03 19:20   ` [PATCH] " Uwe Kleine-König
2009-11-01 21:06 ` [PATCH] mfd/mc13783: near complete rewrite Uwe Kleine-König
2009-11-02 11:51 ` Mark Brown
2009-11-02 13:58   ` Uwe Kleine-König
2009-11-02 14:09     ` Mark Brown
2009-11-02 14:32       ` Uwe Kleine-König
2009-11-02 15:12         ` Mark Brown
2009-11-02 20:56   ` [PATCH] mfd/mc13783: change type of irq handlers to irq_handler_t Uwe Kleine-König
2009-11-03 19:31     ` [PATCH] mfd/mc13783: near complete rewrite Uwe Kleine-König
2009-11-04 18:35       ` Samuel Ortiz
2009-11-04 22:28         ` Uwe Kleine-König
2009-11-05 22:31           ` Samuel Ortiz
2009-11-05 23:53             ` Uwe Kleine-König
2009-11-05 23:56               ` Uwe Kleine-König
2009-11-06  0:28                 ` Samuel Ortiz
2009-11-10  8:18                   ` [PATCH 1/2] regulator/mc13783: rename source file to match other drivers Uwe Kleine-König
2009-11-10  8:18                     ` [PATCH 2/2] regulator/mc13783: various cleanups Uwe Kleine-König
2009-11-10 13:08                       ` Mark Brown [this message]
2009-11-11 14:11                       ` Liam Girdwood
2009-11-11 14:16                         ` Uwe Kleine-König
2009-11-11 14:30                           ` Liam Girdwood
2009-11-10 11:44                     ` [PATCH 1/2] regulator/mc13783: rename source file to match other drivers Mark Brown
2009-11-11 14:09                     ` Liam Girdwood
2009-11-24 21:44                   ` [PATCH] mfd/mc13783: near complete rewrite Uwe Kleine-König
2009-11-24 23:26                     ` Samuel Ortiz
2009-12-02 18:54                       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091110130849.GE16200@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=s.hauer@pengutronix.de \
    --cc=sameo@linux.intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox