From: Pavel Machek <pavel@ucw.cz>
To: Daniel Mack <daniel@caiaq.de>
Cc: David Newall <davidn@davidnewall.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Clemens Ladisch <clemens@ladisch.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vt: make the default cursor shape configurable
Date: Tue, 10 Nov 2009 22:09:41 +0100 [thread overview]
Message-ID: <20091110210940.GA1590@ucw.cz> (raw)
In-Reply-To: <20091109220944.GH14091@buzzloop.caiaq.de>
On Mon 2009-11-09 23:09:44, Daniel Mack wrote:
> On Tue, Nov 10, 2009 at 04:28:03AM +1030, David Newall wrote:
> > Daniel Mack wrote:
> > > And even if the cursor behaviour is changable at runtime, I don't see
> > > why it shouldn't have a selectable compile time default. Which is what
> > > the patch adds.
> >
> >
> > It seems like adding cruft to the kernel that is just as effectively
> > available at run-time. Where does it end? Do we eventually add bash to
> > the kernel?
>
> One more thing:
>
> Clemens' last patch didn't add anything to the kernel's binary size.
> It didn't slow down anything either, as there is no run-time condition
> evaluation. It just makes something configurable which was hard
> coded before. So where's the cruft?
The number of configs to test just got bigger. 100% bigger in
fact. Every single developer will have to answer 'do you want blinking
cursor?' when your patch is merged.
config options _are_ expensive.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-11-10 21:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 9:17 [PATCH] fbcon: make cursor display conditional Daniel Mack
2009-11-06 8:16 ` Clemens Ladisch
2009-11-06 14:39 ` Andrea Righi
2009-11-06 16:45 ` Daniel Mack
2009-11-09 8:35 ` Clemens Ladisch
2009-11-09 9:10 ` Daniel Mack
2009-11-09 9:15 ` [PATCH] vt: make the default cursor shape configurable Clemens Ladisch
2009-11-09 9:53 ` Alan Cox
2009-11-09 11:26 ` Clemens Ladisch
2009-11-09 11:46 ` Alan Cox
2009-11-09 12:21 ` Clemens Ladisch
2009-11-09 14:50 ` Daniel Mack
2009-11-09 17:58 ` David Newall
2009-11-09 18:07 ` Daniel Mack
2009-11-09 22:09 ` Daniel Mack
2009-11-10 12:05 ` David Newall
2009-11-10 12:30 ` Daniel Mack
2009-11-10 12:36 ` David Newall
2009-11-10 12:39 ` Daniel Mack
2009-11-10 21:09 ` Pavel Machek [this message]
2009-11-10 23:26 ` Andrew Morton
2009-11-11 6:56 ` Clemens Ladisch
2009-11-11 7:54 ` Pavel Machek
2009-11-12 22:05 ` Andrew Morton
2009-11-13 7:28 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110210940.GA1590@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=clemens@ladisch.de \
--cc=daniel@caiaq.de \
--cc=davidn@davidnewall.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox