From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: [PATCH tip/core/rcu 0/4] rcu inline, expedited, ->completed cleanups
Date: Tue, 10 Nov 2009 13:36:51 -0800 [thread overview]
Message-ID: <20091110213651.GA21411@linux.vnet.ibm.com> (raw)
This patchset contains a few fixes from testing and review of treercu.
The review was spurred by the earlier bugs.
1. Some compilers don't like forward references to inline functions.
Make the compiler happy by removing "inline".
2. Although synchronize_sched_expedited() was implemented with a
fastpath to efficiently handle multiple concurrent calls,
the counter increment that enabled this fastpath was omitted.
Add it back in. (And yes, this does make a big difference in
performance and scalability for multiple concurrent calls to
synchronize_sched_expedited(), not that such calls should happen
all that often. Still, no point in bringing the machine to its
knees unnecessarily.)
3. The field rsp->dynticks_completed is now used whether or not
dynticks is enabled. Rename it to rsp->completed_fqs to better
document its new role.
4. Much of the confusion leading to the bugs provoked by testing
with long RCU grace periods was due to the method used to
determine which grace period a given context-switch quiescent
state is to be applied to. This change provides a much more
straightforward detection method for these quiescent states.
The quiescent states induced by force_quiescent_state() still
use the old method, and a separate patch for them is in the
works.
next reply other threads:[~2009-11-10 21:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 21:36 Paul E. McKenney [this message]
2009-11-10 21:37 ` [PATCH tip/core/rcu 1/4] rcu: remove inline from forward-referenced functions Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Remove " tip-bot for Paul E. McKenney
2009-11-10 22:38 ` Joe Perches
2009-11-10 22:59 ` Paul E. McKenney
2009-11-10 23:06 ` Joe Perches
2009-11-10 23:41 ` Paul E. McKenney
2009-11-11 1:03 ` Joe Perches
2009-11-11 1:42 ` Paul E. McKenney
2009-11-11 3:28 ` Joe Perches
2009-11-11 4:50 ` Paul E. McKenney
2009-11-11 5:41 ` Paul E. McKenney
2009-11-11 7:02 ` Ingo Molnar
2009-11-11 19:47 ` Paul E. McKenney
2009-11-10 23:03 ` [PATCH tip/core/rcu 1/4] rcu: remove " Josh Triplett
2009-11-10 21:37 ` [PATCH tip/core/rcu 2/4] rcu: enable synchronize_sched_expedited() fastpath Paul E. McKenney
2009-11-10 22:27 ` [tip:core/rcu] rcu: Enable " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 3/4] rcu: rename dynticks_completed to completed_fqs Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Rename " tip-bot for Paul E. McKenney
2009-11-10 21:37 ` [PATCH tip/core/rcu 4/4] rcu: simplify association of quiescent states with grace periods Paul E. McKenney
2009-11-10 22:28 ` [tip:core/rcu] rcu: Simplify " tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110213651.GA21411@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox