From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404AbZKKBmJ (ORCPT ); Tue, 10 Nov 2009 20:42:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756356AbZKKBmI (ORCPT ); Tue, 10 Nov 2009 20:42:08 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:42939 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756333AbZKKBmG (ORCPT ); Tue, 10 Nov 2009 20:42:06 -0500 Date: Tue, 10 Nov 2009 17:42:22 -0800 From: "Paul E. McKenney" To: Joe Perches Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu, linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/rcu] rcu: Remove inline from forward-referenced functions Message-ID: <20091111014222.GE8424@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1257892710.25443.9.camel@Joe-Laptop.home> <20091110225926.GA8424@linux.vnet.ibm.com> <1257894380.25443.16.camel@Joe-Laptop.home> <20091110234101.GB8424@linux.vnet.ibm.com> <1257901421.25443.34.camel@Joe-Laptop.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1257901421.25443.34.camel@Joe-Laptop.home> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2009 at 05:03:41PM -0800, Joe Perches wrote: > On Tue, 2009-11-10 at 15:41 -0800, Paul E. McKenney wrote: > > On Tue, Nov 10, 2009 at 03:06:20PM -0800, Joe Perches wrote: > > > On Tue, 2009-11-10 at 14:59 -0800, Paul E. McKenney wrote: > > > > > non-inline functions in .h files probably aren't a good idea. > > > > ;-) > > > > Here are my options: > > > [] > > > > Please note that kernel/rcutree_plugin.h is internal to RCU -- only > > > > kernel/rcutree.c includes it, so there is no possibility of conflicting > > > > definitions. > > > > Any options that I am missing? > > > Maybe something like: > > > #ifdef whatever > > > #define RCU_ANNOUNCE "Hierarchical RCU implementation.\n" > > > ... > > > #else > > > #define RCU_ANNOUNCE "Experimental preemptable hierarchical RCU implementation.\n" > > > ... > > > #endif > > > Use pr_info(RCU_ANNOUNCE) instead of rcu_bootup_announce(); > > > ? > > This would still be a forward reference, right? > > No, what I suggest would delete the forward reference and > the rcu_bootup_announce function altogether. I still either have a plugin definition in the non-plugin file kernel/rcutree.c or a forward reference to the macro definition. > The single caller of rcu_bootup_announce in __rcu_init > would become printk(KERN_INFO RCU_ANNOUNCE); > > I wrote the original quoted content above without looking > at the file, just the submitted patch. After looking the > the rcutree files, another option is to do what Ingo did > with sched.c and finesse the #include ".h". > > $ grep "include.*\.c" sched.c > #include "sched_idletask.c" > #include "sched_fair.c" > #include "sched_rt.c" > # include "sched_debug.c" > > So maybe rename rcutree_plugin.h to rcutree_plugin.c and > #include "rcutree_plugin.c" in rcutree.c instead. Hmmm... Thanx, Paul